johnyangk commented on a change in pull request #178: [NEMO-317] Optimize
triggering logic in GroupByKeyAndWindowDoFnTransform
URL: https://github.com/apache/incubator-nemo/pull/178#discussion_r241644565
##########
File path:
compiler/frontend/beam/src/main/java/org/apache/nemo/compiler/frontend/beam/transform/GroupByKeyAndWindowDoFnTransform.java
##########
@@ -134,14 +131,15 @@ public void onData(final WindowedValue<KV<K, InputT>>
element) {
/**
* Process the collected data and trigger timers.
- * @param inputWatermark current input watermark
* @param processingTime processing time
* @param synchronizedTime synchronized time
*/
- private void processElementsAndTriggerTimers(final Watermark inputWatermark,
- final Instant processingTime,
+ private void processElementsAndTriggerTimers(final Instant processingTime,
final Instant synchronizedTime)
{
- for (final Map.Entry<K, List<WindowedValue<InputT>>> entry :
keyToValues.entrySet()) {
Review comment:
👍 for avoiding iterating over 'empty' keys.
(e.g., keys from previous windows that we never encounter in the current
window)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
