johnyangk commented on a change in pull request #180: Fix path to beam resources in examples in README URL: https://github.com/apache/incubator-nemo/pull/180#discussion_r241665971
########## File path: README.md ########## @@ -77,7 +77,7 @@ Please refer to the [Contribution guideline](.github/CONTRIBUTING.md) to contrib ## MapReduce example ./bin/run_beam.sh \ -job_id mr_default \ - -executor_json `pwd`/examples/resources/beam_test_executor_resources.json \ + -executor_json `pwd`/examples/resources/executor/beam_test_executor_resources.json \ -optimization_policy org.apache.nemo.compiler.optimizer.policy.DefaultPolicy \ -user_main org.apache.nemo.examples.beam.WordCount \ -user_args "`pwd`/examples/resources/test_input_wordcount `pwd`/examples/resources/test_output_wordcount" Review comment: Please change this line to: ```bash -user_args "`pwd`/examples/resources/inputs/test_input_wordcount `pwd`/outputs/wordcount" ``` (1) the `inputs` directory was also added in #146 (2) the `outputs` directory can be easier to find ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services