Lars, Is the plan to continue to keep the cleaner as a 32bit exe?
$ file cleaner.exe cleaner.exe: PE32 executable (GUI) Intel 80386, for MS Windows The nlw.exe executable was built as a 64bit exe, which used to be 32bit in previous NetBeans releases. This would prevent using the NBI to create a package that runs on 32bit Windows (not that there should be any reason to be running a 32bit version of Windows in 2019). $ file nlw.exe nlw.exe: PE32+ executable (GUI) x86-64 (stripped to external PDB), for MS Windows This is actually what lead me down the path of embedding the JVM in the installer since 64bit installer will not find a JRE if there is only a 32bit JVM installed on Windows. It could be worked around by using the --javahome command line option, but embedding it provides a better user experience. --Christian On Thu, Sep 12, 2019 at 4:05 PM Lars Bruun-Hansen <lbruunhan...@gmail.com> wrote: > I've filed a Jira ticket : > https://issues.apache.org/jira/browse/NETBEANS-3094 > with the aim to change the C code for the cleaner.exe to be able to > delete read-only files too. It is rather trivial. I've assigned it to > myself. > > @Emilian Bold: Where would I document? Please point me in right > direction. Thanks. > > On Thu, Sep 12, 2019 at 9:46 PM Christian Oyarzun <c...@oyarzun.net> wrote: > > > > Oliver, it is just a question of changing the permissions on the files > > before zipping the JRE. > > > > I'm using a modified version (JRE instead of JDK) of > > jMonkeyEngine's script to create the JRE unzipsfx files. > > > > It's a question of adding the following to > > > https://github.com/jMonkeyEngine/sdk/blob/d72264096f8c75fdf558bbb157dd573664ccf9bb/jdks/download-jdks.sh#L146 > > > > find . -exec chmod u+w {} \; # Make all file writable to allow > > uninstaller's cleaner to remove file > > > > I'll send them a PR. > > > > --Christian > > > > > > On Thu, Sep 12, 2019 at 3:17 PM Oliver Rettig <oliver.ret...@orat.de> > wrote: > > > > > Hi, > > > I remember on such problems also with Netbeans 8.2. It had todo with > > > access rights. I am > > > interested in if you can figure it out. > > > best regards > > > Oliver > > > > Is anyone packaging the JRE in a RCP installer using Netbeans 11.1 > > > > following these instructions? > > > > https://dzone.com/articles/including-jre-in-nbi > > > > > > > > While this works fine under Linux , the Windows uninstaller does not > > > delete > > > > some of the JRE files. > > > > > > > > C:\Program Files\rcpapp>dir /s /b > > > > C:\Program Files\rcpapp\jre > > > > C:\Program Files\rcpapp\jre\ASSEMBLY_EXCEPTION > > > > C:\Program Files\rcpapp\jre\lib > > > > C:\Program Files\rcpapp\jre\LICENSE > > > > C:\Program Files\rcpapp\jre\THIRD_PARTY_README > > > > C:\Program Files\rcpapp\jre\lib\cmm > > > > C:\Program Files\rcpapp\jre\lib\currency.data > > > > C:\Program Files\rcpapp\jre\lib\fontconfig.bfc > > > > C:\Program Files\rcpapp\jre\lib\management > > > > C:\Program Files\rcpapp\jre\lib\cmm\CIEXYZ.pf > > > > C:\Program Files\rcpapp\jre\lib\cmm\GRAY.pf > > > > C:\Program Files\rcpapp\jre\lib\cmm\LINEAR_RGB.pf > > > > C:\Program Files\rcpapp\jre\lib\cmm\PYCC.pf > > > > C:\Program Files\rcpapp\jre\lib\cmm\sRGB.pf > > > > C:\Program > Files\rcpapp\jre\lib\management\jmxremote.password.template > > > > C:\Program Files\rcpapp\jre\lib\management\snmp.acl.template > > > > > > > > Any ideas on why these files are not deleted? Could it be the > > > INITIAL_DELAY > > > > is too short in the cleaner.exe? > > > > > > > > > > > > https://github.com/apache/netbeans/blob/0580490be48a9a2ec6279218fd0e39561aff > > > > dab8/nbi/engine/native/cleaner/windows/src/main.c#L28 > > > > > > > > Thanks, > > > > Christian > > > > > > > > > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@netbeans.apache.org > For additional commands, e-mail: dev-h...@netbeans.apache.org > > For further information about the NetBeans mailing lists, visit: > https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists > > > >
