+1 (binding) Moreover I have done an evaluation of Geertjan's below quoted report. The hang in `GtkJavaScriptTest` is caused by a buggy expectation in the test. Here is my fix: https://github.com/apache/netbeans-html4j/commit/8f34d2f410c787778a03129eae874fd60ad55e88
With the 8f34d2f410c patch, I was able to successfully perform "mvn package" will all these JVMs: JDK8_222, JDK11, JDK13 running on: - Ubuntu 18.04 - the WebKitPresenter tests worked and passed OK - Ubuntu 19.10 - the WebKitPresenter tests were skipped I assume the behavior on Mac (as tested by Geertjan) is subject to the same error and the 8f34d2f410c patch fixes it as well. Travis seems to agree: https://travis-ci.org/apache/netbeans-html4j/builds/604801383 Given the error is in test code only and doesn't affect the code staged at Maven repository: https://repository.apache.org/content/repositories/orgapachenetbeans-1051/ neither it affects the source (if consumed with "mvn package -DskipTests"), I am giving my +1 anyway. -jt Geertjan Wielenga <geert...@apache.org> wrote: > +1 > > My environment on Mac OSX Sierra 10.13.6: > openjdk version "13" 2019-09-17 > > OpenJDK Runtime Environment (build 13+33) > > OpenJDK 64-Bit Server VM (build 13+33, mixed mode, sharing) > > > I ran "mvn package", which hangs (waited a while) here: > > ------------------------------------------------------- > > T E S T S > > ------------------------------------------------------- > > Running org.netbeans.html.presenters.webkit.GtkJavaScriptTest > > Configuring TestNG with: TestNG652Configurator > > > > On Tue, Oct 29, 2019 at 12:53 PM Jaroslav Tulach < > jaroslav.tul...@gmail.com> > wrote: > > > Hi. > > To accommodate the recent donation of various presenters by DukeHoff > GmbH, > > I've spend a bit of my vacation time and prepared release 1.7 of Apache > > NetBeans HTML/Java API. Please find the source at > > > > > > > https://dist.apache.org/repos/dist/dev/netbeans/netbeans-html4j/netbeans-html4j-1.7/ > > < > > > https://dist.apache.org/repos/dist/dev/incubator/netbeans/incubating-netbeans-html4j/incubating-netbeans-html4j-1.6/ > > > > > > > and the staged Maven artifacts at > > > https://repository.apache.org/content/repositories/orgapachenetbeans-1051/ > > < > > > https://repository.apache.org/content/repositories/orgapachenetbeans-1002/ > > > > > > > Please cast your vote during next 72h. > > > > What can you verify? > > > > ## checksums, signatures, etc. > > > > Obviously those should be correct. > > > > ## if it builds > > > > I used "mvn package -DskipTests" and I believe the compilation shall > > succeed on JDK8, JDK11, JDK13 > > > > ## if the tests pass > > > > Use "mvn package". They may not - especially the newly donated modules > are > > very sensitive to surrounding environment. Getting them run on all > > important platforms may take some time. > > > > If you want to report your findings, then please include the version of > > operating system, version of JDK, version of the browser, etc. You may > also > > want to run them individually. E.g. "mvn -f browser test" or "mvn -f > webkit > > test". > > > > I know that browser doesn't seem to run on Windows 8 with Internet > Explorer > > (but it runs with Firefox instead). I know that webkit does run on Ubuntu > > 19.04 with proper libraries ("libwebkit") installed. But those libraries > > aren't present in Ubuntu 19.10 - there is "libwebkit2" and somebody would > > have to adjust the code to use the "libwebkit2" code. In short, there are > > many broken things in the browser and webkit modules - volunteers > welcomed > > to make them run! > > > > ## How to cast your vote? > > > > I propose the goal of 1.7 release to be to compile and execute its tests > > (except browser and webkit modules) on all supported platforms. We should > > collect the test failures in browser and webkit modules and find some > > volunteers to fix them for some upcoming update release. > > >
