+1 I just tried the latest FlatLAF version, both dark and light, on HiDPI and regular displays on Windows. It certainly looks complete enough to remove the "experimental" mark!
Some possible tweaks for the future (besides my earlier comments about tab button borders): * In the Property Sheet, horizontal separator lines are missing on the right-hand side, where property values are painted. * The text in JButton components could be moved up 1 pixel, for better vertical centering. * The main editor tab row has a slight blue tint on both the dark and light themes. I have a slight preference for keeping background colors for non-selected components in a neutral shade of grey. * I wonder if it would be possible to get rid of the "Maximize use of native look and feel" checkbox in the options dialog (corresponds to WinSysPrefs.MAXIMIZE_NATIVE_LAF). As far as I can see grepping the sources, the only thing it controls is whether to use the native file chooser. Are there still cases where this needs to be used? Thanks for this great contribution to NetBeans! -- Eirik -----Original Message----- From: Karl Tauber <[email protected]> Sent: Tuesday, January 7, 2020 7:32 PM To: [email protected] Subject: Re: Remove (experimental) from FlatLaf Dark +1 I'm already working on 2., 3. and on NETBEANS-3657. PRs are coming soon... You can change the progress bar height in FlatLaf.properties. The default is: ProgressBar.horizontalSize=146,4 Try whether this is better: ProgressBar.horizontalSize=146,6 I also like to improve the editor/view tabs to address Eirik's comments in PR 1771. And look at the other dark LaFs to find colors that need fixes in FlatLaf. Karl On 07.01.2020 18:07, Laszlo Kishalmi wrote: > Dear all, Karl, > > Feature freeze is closing for 11.3 (next week). Thanks to Karl and > other active community members, FlatLaf Dark has progressed a lot and > it is a completely usable modern dark Laf for NetBeans. It can make > the Darcula plugin (AFAIK, the most downloaded NetBeans plugin from > the plugin > portal) obsolete. I see only 4 fixable issues: > > 1. Form designer: https://github.com/apache/netbeans/pull/1846 > > 2. The versioning annotations and diff colors needs some adjustments > to the dark theme. > > 3. The border color of the search bar does not follow the LaF palette. > I guess that's just one line in a property file change. > > 4. Unbounded progress bar height is really small. (I do not know that > it is by design, but for me it's visually confusing) > > Does anybody see anything else, before we could remove the > (experimental) adjective from this LaF? > > BTW FlatLaf Light looks good as well it just missing some coloring > review and perhaps a fitting Editor Color theme. > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [email protected] > For additional commands, e-mail: [email protected] > > For further information about the NetBeans mailing lists, visit: > https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists > > > > --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
