Ahoj Sváťo, thanks a lot for undertaking the uneasy quest of "Fixing commit validation" and eliminating all the debris introduced since it got disabled. Validation is important for proper ordering, behavior and smooth start without tons of useless warnings. Unless I am mistaken it contains tens of useful tests and you have successfully passed the majority of them, right?
Can we integrate that part now and leave the difficult topic of MIME registrations orderings for next week? Commit validation with disabled MIME ordering test is still more useful than no validation at all! Thank you for polishing the state of NetBeans IDE! -jt st 16. 9. 2020 v 20:14 odesílatel Svata Dedic <[email protected]> napsal: > Hi, > > I am trying to fix "commit-validation" test that (among other things) > ensures some consistency in registration layers, in particular order of > registrations in MIME Lookup. > > The explanation got terribly long, so I put up a Wiki page, see > > https://cwiki.apache.org/confluence/display/NETBEANS/File+Ordering+Change+proposal > for full details. > > Short summary: > - there's NO WAY how to register a service in Editors/ (unspecified > mimetype), that would pass current commit-validation > - the unspecified mimetype ("") was specifically designed to define > universal services, for all editors (without that, this is what the > entire MIME inheritance is about) > - once some obscure module registers a service in "" MIME type, it is > likely to force all distribution modules to use positions in their > registrations from that time onwards. > > POSSIBLE SOLUTIONS: > * Change test > * Define positions in the whole codebase + maintain > * Improve FileUtil.getOrder() contract > > Again, please see > > https://cwiki.apache.org/confluence/display/NETBEANS/File+Ordering+Change+proposa > for all the details. > > Relevant PRs and branches: > * https://github.com/apache/netbeans/pull/2359 > * https://github.com/apache/netbeans/pull/2360 > * > > https://github.com/apache/netbeans/compare/master...sdedic:origin/bugfix/commitvalidation-fixes3 > > Please share your thoughts, help me select (or discover) the best (or at > least effective) solution. > > Thanks, > -Svata > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [email protected] > For additional commands, e-mail: [email protected] > > For further information about the NetBeans mailing lists, visit: > https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists > > > >
