Hi, sorry, yes merges are ok. The intention here was to prevent more merges, that could hinder a revert. As Martin did the best thing and fixed the issue, that is not needed anymore.
Greetings Matthias Am 15. Oktober 2021 06:56:54 MESZ schrieb "László Kishalmi" <laszlo.kisha...@gmail.com>: >Is master open for merges after https://github.com/apache/netbeans/pull/3244 >? > >On Tue, Oct 12, 2021 at 10:22 PM Jaroslav Tulach <jaroslav.tul...@gmail.com> >wrote: > >> > PLEASE DO NOT MERGE FURTHER CHANGES >> >> I can see that the revert PR-3181 wasn't approved by Martin Entlicher and >> that >> his another PR-3204 hasn't been reviewed and approved by you. >> >> Looks like serious communication breakdown. Thanks for letting us know >> before >> starting another round of reverts. >> >> > What to do about this? The best case scenario: >> >> Treat this as a bug, talk to each other, make debugger work in 12.6 and >> let >> make the debugger work fast. >> -jt >> >> > Hi, >> > >> > I want to raise awareness of the broken state of debugging in NetBeans >> > IDE. I raise it here and now, because reverting the initial changes >> > alone does not help anymore. >> > >> > The problem starts with this PR: >> > >> > https://github.com/apache/netbeans/pull/3158 >> > >> > that was reverted via >> > >> > https://github.com/apache/netbeans/pull/3181 >> > >> > and resubmitted as >> > >> > https://github.com/apache/netbeans/pull/3204 >> > >> > After the merge of PR3204 it looked ok, but I did not test with >> > "Suspend all threads" and this is now totally broken in NetBeans >> > master. >> > >> > See the final comment in PR 3204 for a description of the issue. >> > >> > The big question is: What to do about this? A trivial revert fails as >> > there are conflicting changes in the area. >> > >> > The best case scenario: Debugging will be fixed and be stable again as >> > it was in the past. >> > >> > Worst case scenario: We revert all changes, that touch the JPDA code >> > and everything, that causes conflicts. >> > >> > I would prefer the best case scenario. >> > >> > Greetings >> > >> > Matthias >> > >> > >> > --------------------------------------------------------------------- >> > To unsubscribe, e-mail: dev-unsubscr...@netbeans.apache.org >> > For additional commands, e-mail: dev-h...@netbeans.apache.org >> > >> > For further information about the NetBeans mailing lists, visit: >> > https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists >> >> >> >> >> >> --------------------------------------------------------------------- >> To unsubscribe, e-mail: dev-unsubscr...@netbeans.apache.org >> For additional commands, e-mail: dev-h...@netbeans.apache.org >> >> For further information about the NetBeans mailing lists, visit: >> https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists >> >> >> >>
