+1 (binding)
- Verified SHA512 and Signature
- Contents of source zip matches the reporitoy state
- Eyeballed LICENSE and NOTICE files
- Build from source
- the binary was not tested!
There seems to be a build problem with recent versions of npm.
PrepareBundles.java tries to find licenses for all "modules" in the
node_modules and does this by iterating over all childs of that
directory. It seems npm in version 7.5.2 creates a file ".package-
lock.json", which fails to resolve to a license file. I had to patch
the PrepareBundles.java by handling the special case:
# This patch file was generated by NetBeans IDE
# It uses platform neutral UTF-8 encoding and \n newlines.
--- a/PrepareBundles
+++ b/PrepareBundles.java
@@ -101,6 +101,10 @@
try (DirectoryStream<Path> ds =
Files.newDirectoryStream(packagesDir.resolve("node_modules"));
Writer binariesList = new
OutputStreamWriter(Files.newOutputStream(bundlesDir.resolve("binaries-list")),
"UTF-8")) {
for (Path module : ds) {
+ if(! Files.isDirectory(module)) {
+ continue;
+ }
+
if (".bin".equals(module.getFileName().toString())) continue;
if ("@types".equals(module.getFileName().toString())) continue;
if ("@ungap".equals(module.getFileName().toString())) {
Am Donnerstag, dem 14.10.2021 um 07:31 +0000 schrieb Martin Balin:
> Dear community,
> let's update the Apache NetBeans Language Server extension on VSCode
> Marketplace
> https://marketplace.visualstudio.com/items?itemName=ASF.apache-netbeans-java
> to significantly improved version 12.5.301.
>
> https://dist.apache.org/repos/dist/dev/netbeans/netbeans-vscode-ext/12.5.301/
>
> The primary voting artifact is the source
> https://dist.apache.org/repos/dist/dev/netbeans/netbeans-vscode-ext/12.5.301/apache-netbeans-java-12.5.301-src.zip
> with SHA-512 sum:
> 11b460cfaa8d98f9612320c0040e7f928d0b6af904427ad92867ef64c5df3ec7d12192b3980e10f04e15033d0f5ddd57ec0cdda3bdec8c706be541b8f722ff13
>
> and PGP signature:
> https://dist.apache.org/repos/dist/dev/netbeans/netbeans-vscode-ext/12.5.301/apache-netbeans-java-12.5.301-src.zip.asc
>
> The artifacts have been generated by
> https://ci-builds.apache.org/job/Netbeans/job/netbeans-vscode/650/ from git
> revision b19730846d986575f26b3b70236d2142dde18157
>
> Use following commands to build your own 12.5.301 VSIX binary:
>
> tmp$ unzip apache-netbeans-java-12.5.301-src.zip
>
> tmp$ ant build
> -Dmetabuild.jsonurl=https://raw.githubusercontent.com/JaroslavTulach/netbeans-jenkins-lib/jtulach/vsnetbeans_preview_1253/meta/netbeansrelease.json
>
> tmp$ cd java/java.lsp.server
>
> java.lsp.server$ ant build-vscode-ext -Dvsix.version=12.5.301
> -D3rdparty.modules=.*nbjavac.*
>
> The special netbeansrelease.json is needed now (and was used in build job
> #650) due to pending PR to netbeans-jenkins-lib
> https://github.com/apache/netbeans-jenkins-lib/pull/35
>
> In addition to the source ZIP file, we are also voting about convenience
> binary:
> https://dist.apache.org/repos/dist/dev/netbeans/netbeans-vscode-ext/12.5.301/apache-netbeans-java-12.5.301.vsix
> with SHA512 checksum:
> ed94506362a3f6add8e3cd6f4f50f94178d761701001045158ee9d2a7935136fe706ff8a3e3c6c04be2b2feb422e72219959435ddec93c512cfb79ca3b30108b
>
> and
> https://dist.apache.org/repos/dist/dev/netbeans/netbeans-vscode-ext/12.5.301/apache-netbeans-java-12.5.301.vsix.asc
> PGP signature.
>
> The binary has been produced by the same job run #650, from the same commit.
>
> This vote is going to be open at least 72 hours, vote with +1, 0, and -1 as
> usual. Please mark your vote with (binding) if you're an Apache NetBeans PMC
> member.
>
> Thank you,
> Martin Balín
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [email protected]
> For additional commands, e-mail: [email protected]
>
> For further information about the NetBeans mailing lists, visit:
> https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
>
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
