Hi, Am Mittwoch, dem 27.10.2021 um 12:15 +0100 schrieb Neil C Smith: > On Tue, 26 Oct 2021 at 11:23, Neil C Smith <neilcsm...@apache.org> wrote: > > On Tue, 26 Oct 2021 at 10:13, Eric Barboni <sk...@apache.org> wrote: > > > Rat process is showing the following file > > > > > > https://gitbox.apache.org/repos/asf/netbeans/tree/master/ide/xml.retriever/t > > > est/unit/src/org/netbeans/modules/xml/retriever/impl/badssl.com-client.p12 > > > > > > as unapproved. > > > > Curious! What exactly did you run? It passes here, and passed the > > rat test in the PR that introduced it. Although it does show as B not > > AL. It perhaps shouldn't pass? > > Firstly, thanks for fixing the NBI build. Looks like we have an RC1 > which I'm just testing. > > But we might have a RAT issue to solve before release here. > > Interestingly, comparing the saved RAT report on the build server with > local, it seems this file is picked up as text rather than binary. > That might be the cause of differences in results?
I had a look at rat, verify-libs-and-licenses and verify-all-libs-and- licenses. The latter is not really critical, but showed a few gray areas. Contrib in general should be ignored. This is my suggested fix (opened against delivery): https://github.com/apache/netbeans/pull/3276 I think the description covers the changes pretty good, the only think not in the description is the clarification, that the changes to the contrib licenses are not to fix them, but to get them in a better shape. Greetings Matthias --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@netbeans.apache.org For additional commands, e-mail: dev-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
