Hi Matthias,
Some comments inlined below.
El 2/1/22 a las 10:42, Matthias Bläsing escribió:
Hi Antonio,
Am Samstag, dem 01.01.2022 um 11:40 +0100 schrieb antonio:
Here is a proposal to integrate a subset of cnd in Apache NetBeans
https://cwiki.apache.org/confluence/display/NETBEANS/cnd+integration+proposal%3A+cnd-small
Comments/reviews are welcome.
I had a first look at cnd-small. If I read this correctly this is based
on the CND branch, where Jan imported the 4+5 donation zip. This sounds
sane.
For this branch I have only one comment:
5c7ade6e6a2685f8cb8777a5b42bc656fced7576 [cnd] Removed non-project related
modules
I would not remove the modules, but move them to the "contrib"
directory. That way we don't loose track of the files in the git
history (direct renames should be trackable) and the already happend
license cleanup. If then a module is to be resurrected, it is a move
(first) commit and then some "enabling" commits. We then don't have to
reevaluate where "all these new files" come from.
+1. Very good idea.
I'm not sure about the comment for cnd-small/3:
The cpplite.editor indeed builds on top of the lsp.client module. The
class org.netbeans.modules.cpplite.editor.lsp.LanguageServerImpl is the
binding between the configuration, that the cpplite.editor module
provides and the LSP API, that is provided by lsp.client. If I read the
code correctly, ccls is used, if configured and switches over to clangd
else.
Yep. I have to rephrase that. cpplite does indeed use lsp.client. The
user interface is somehow duplicated, though:
- lsp.client has a panel (Editors/Language Servers) in the Options Panel
where language servers are registered.
- cpplite has instead a C/C++ top-level tab in the Options Panel, where
it automatically checks for ccls and clangd in the PATH. That's very
handy. But not clangd nor ccls are registered in the panel in lsp.client.
In general you seem to have a plan and cut it down, so that it is
manageable. If you need help, feel free to ask. Even gettings parts of
CND into mainline again will help and improve the situation. What is
more it will send the right message: There is development going on and
maybe people will join in instead of complaining :-)
+1. I'll ask for help as required.
Thank you,
Antonio
Thank you
Matthias
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
