I was supplementing and refactoring unit tests for
/platform/openide.util/src/org/openide/util/BaseUtilities.java
<https://github.com/apache/netbeans/blob/master/platform/openide.util/src/org/openide/util/BaseUtilities.java>


and I found a “*wrapStringToArray
<https://github.com/apache/netbeans/blob/71f182d6f160bcb3879c38c1f9f9a4925f18074f/platform/openide.util/src/org/openide/util/BaseUtilities.java#L306>*”
method  which is only used in platform\openide.util.ui\src\
<https://github.com/apache/netbeans/blob/master/platform/openide.util.ui/src/org/openide/util/Utilities.java>
org\openide\util\Utilities.
<https://github.com/apache/netbeans/blob/master/platform/openide.util.ui/src/org/openide/util/Utilities.java>
java
<https://github.com/apache/netbeans/blob/master/platform/openide.util.ui/src/org/openide/util/Utilities.java>
(lines 382 – 401)



Which defines function of exact same signature and cals the one from
*BaseUtilities.**java.*

*Utilities.wrapStringToArray is not used anywhere.*






There is another methods present in *BaseUtilities.java* called "
*wrapString*" which in turn invokes "*wrapStringToArray*".
platform\openide.dialogs\src\org\openide\NotifyDescriptor.java
<https://github.com/apache/netbeans/blob/71f182d6f160bcb3879c38c1f9f9a4925f18074f/platform/openide.dialogs/src/org/openide/NotifyDescriptor.java#L972>

[image: obraz.png]


So I thought... maybe it makes sense to remove *Utilities.wrapStringToArray*
and make *BaseUtilities.wrapStringToArray* private to be able to refactor
BaseUtilities.wrapString into more efficient implementation (after
writing characterization
tests <https://en.wikipedia.org/wiki/Characterization_test>first).




-- 
Łukasz Bownik

Reply via email to