On 02.05.22 18:11, Matthias Bläsing wrote:
Hi Eric,
Am Montag, dem 02.05.2022 um 11:32 +0200 schrieb Eric Barboni:
It seems that PR #4004 and #4007 did not apply correctly to delivery branch
and by consequence to master branch. Somehow should be my fault
lets replace "my fault" with "I might have caused". Here is a record of
a potential problem:
https://github.com/apache/netbeans/pull/4031
https://github.com/apache/netbeans/pull/4032
both PRs show this line:
ebarboni force-pushed the delivery branch from 74e1e5f to 217f7df 4 days ago
(2022-04-28 13:58 CEST)
The easiest way to know what was dropped would be:
- get a list of all closed PRs on github with a change date in the last 4-5 days
- check which is targettet to delivery
- check if the changes from that PR are in delivery
I did something similar manually, I used the search filter of "is:pr
is:closed base:delivery milestone:NB14" on gh, opened them all and
checked by clicking on the integration hash if the commit was in
delivery. I did it a second time without the NB14 just to be sure.
Thats how I found the second PR. The first I found after decompiling RC2
to confirm that one of my PRs was in fact not there and I am not
imagining it :)
-mbien
Maybe this helps
Matthias
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
