Dne 09. 05. 22 v 22:17 Łukasz Bownik napsal(a):
The problem is that another method of this class
*public String processPattern(String newPattern) throws
IllegalArgumentException*
becomes useless now.
I think it should be removed.
In general no API can be *ever* removed once published in a NetBeans
release. While there's no client of this in the Apache codebase, the
openide-util is also published as a maven artifact and can be consumed
by anyone anywhere.
My reasoning is the following (based on original implementation)
(not disputing the reasons at all)
But.. If we want to keep this API structure unchanged then I could provide
a stubbed implementation like
@deprecated <https://github.com/deprecated>
public String processPattern(String newPattern) throws
IllegalArgumentException {
return newPattern;
}
would it be acceptable?
I don't think so - if the client is expecting some semantics of the
A (potential) client might expect existing semantic of the return value,
even de-facto one (since @return is not javadoc-ed); we should not break
that "contract". The method can be removed in the next release version
(/x after the codename) of the openide.util - if it ever reaches a next
release version at all.
Actually removing a method from the API can be done in a binary
backwards-compatible way; but it would be an overkill in this case, IMHO.
Make the method deprecated, javadoc-explain why, and cut out everything
except construction of the return value. Let's add it to all our old
past sins.
-S.
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
