Hi, Should all be fixed. Please note that to fail the build, one should ask for that in the pom.xml using "failOnWarnings" like here: https://github.com/apache/netbeans-jackpot30/blob/db82ffa0d6aae6d18545f5a6effe44cfaeff3fbb/cmdline/maven/tests/fail-on-warnings/pom.xml#L50
Jan On Tue, May 24, 2022 at 11:50 AM Jaroslav Tulach <[email protected]> wrote: > This is a fix for the version selection. Don't we also need a fix that > would fail the build? > -jt > > > Dne út 24. 5. 2022 7:35 uživatel Jan Lahoda <[email protected]> napsal: > > > Oops. Fix: > > https://github.com/apache/netbeans-jackpot30/pull/26 > > > > Please review. > > > > Thanks for testing! > > > > Jan > > > > On Mon, May 23, 2022 at 7:54 AM Jaroslav Tulach < > [email protected] > > > > > wrote: > > > > > -1 > > > > > > Maybe I don't understand how to use Jackpot properly, but if I try: > > > > > > ``` > > > netbeans-html4j$ git diff > > > diff --git a/json-tck/pom.xml b/json-tck/pom.xml > > > index 68242488..8b15e154 100644 > > > --- a/json-tck/pom.xml > > > +++ b/json-tck/pom.xml > > > @@ -58,7 +58,9 @@ > > > <plugin> > > > <groupId>org.apache.netbeans.modules.jackpot30</groupId> > > > <artifactId>jackpot30-maven-plugin</artifactId> > > > - <version>12.3</version> > > > + <version>13.0</version> > > > + <configuration> > > > + </configuration> > > > </plugin> > > > </plugins> > > > </build> > > > ``` > > > > > > and then run: > > > ``` > > > netbeans-html4j$ mvn clean install -DskipTests > > > netbeans-html4j$ mvn -f json-tck/ jackpot30:analyze > > > --- jackpot30-maven-plugin:13.0:analyze (default-cli) @ > > > net.java.html.json.tck > > > unrecognized source level specification: 17 > > > BUILD SUCCESS > > > `` > > > > > > #1 - I am not sure why it cannot recognize source level 17 > > > #2 - I don't understand why it prints "BUILD SUCCESS" > > > #3 - it certainly doesn't detect any errors[1] > > > > > > -jt > > > > > > [1] The "warning" that IDE detects properly, but `jackpot30:analyze` > > > doesn't: > > > > > > --- a/json-tck/src/main/java/net/java/html/js/tests/JsUtils.java > > > +++ b/json-tck/src/main/java/net/java/html/js/tests/JsUtils.java > > > @@ -19,13 +19,17 @@ > > > package net.java.html.js.tests; > > > > > > import java.io.StringReader; > > > +import java.util.ArrayList; > > > import java.util.ServiceLoader; > > > import net.java.html.json.Models; > > > import org.netbeans.html.boot.spi.Fn; > > > import org.netbeans.html.json.tck.JavaScriptTCK; > > > > > > public class JsUtils { > > > + > > > + private final ArrayList<Object> list; > > > private JsUtils() { > > > + list = new ArrayList<>(); > > > } > > > > > > private static JavaScriptTCK instantiatedJsTCK; > > > > > > Dne neděle 22. května 2022 9:12:10 CEST, Jan Lahoda napsal(a): > > > > Dear all, > > > > > > > > I'd like to release the standalone Java Hints tool ("jackpot") based > on > > > > Apache NetBeans 13.0, including the nb-javac. > > > > > > > > The release is here: > > > > > > > > > > https://dist.apache.org/repos/dist/dev/netbeans/netbeans-jackpot/netbeans-ja > > > > ckpot-13.0-vc1/apache-netbeans-jackpot-13.0.zip > > > > > > > > Signature file: > > > > > > > > > > https://dist.apache.org/repos/dist/dev/netbeans/netbeans-jackpot/netbeans-ja > > > > ckpot-13.0-vc1/apache-netbeans-jackpot-13.0.zip.asc > > > > > > > > SHA512: > > > > > > > > > > 7c1bf5e57a550791e2c9ca56578ce62c403bd6d2cae580a55cae09ad54b3002a990e05a23a5a > > > > 337268b22141e57c7b1073644a1dd5c0f630592da070295bbcf9 > > > > apache-netbeans-jackpot-13.0.zip > > > > > > > > KEYS file: > > > > > > > > https://dist.apache.org/repos/dist/release/netbeans/KEYS > > > > > > > > Apache NetBeans Jackpot 3.0 Git Repo tag: > > > > > > > > > > https://github.com/apache/netbeans-jackpot30/releases/tag/netbeans-jackpot-1 > > > > 3.0-vc1 > > > > > > > > Convenience binaries: > > > > -built standalone tool: > > > > > > > > > > https://dist.apache.org/repos/dist/dev/netbeans/netbeans-jackpot/netbeans-ja > > > > ckpot-13.0-vc1/apache-netbeans-jackpot-13.0-bin.zip > > > > > > > > Its signature file: > > > > > > > > > > https://dist.apache.org/repos/dist/dev/netbeans/netbeans-jackpot/netbeans-ja > > > > ckpot-13.0-vc1/apache-netbeans-jackpot-13.0-bin.zip.asc > > > > > > > > and its SHA512: > > > > > > > > > > 3746cc0ae84ed61395db7c254254476d451f96366789feb2a02e92b630c6ea2e150baa1c7190 > > > > f089e1b259319191d08a302211c47e648615b4b130de7cb9b036 > > > > apache-netbeans-jackpot-13.0-bin.zip > > > > > > > > -there is also a plugin staging Maven repository here: > > > > > > > > > > https://repository.apache.org/content/repositories/orgapachenetbeans-1112/ > > > > > > > > This vote is going to be open at least 72 hours, please vote with +1, > > 0, > > > > and -1 as usual. > > > > > > > > Thanks for any feedback! > > > > > > > > Jan > > > > > > > > > > > > > > > > > > --------------------------------------------------------------------- > > > To unsubscribe, e-mail: [email protected] > > > For additional commands, e-mail: [email protected] > > > > > > For further information about the NetBeans mailing lists, visit: > > > https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists > > > > > > > > > > > > > > >
