On 22/10/28 3:08 PM, Michael Bien wrote:
and I wish I could count on the fact that there's been no bug report;
but that's another story.
Given that sigtest failed, I'm surprised that there's so much
surprise that there's an issue.
nobody is surprised. If you would have read the PR you would have seen
that the signature change was discussed before integration and rightly
considered harmless.
I read the PR yesterday.
I wasn't clear. I was surprised that people were surprised that I think
the PR broke something.
sigtest failed, and it was fixed by modifying sigtest. I won't say it
was the wrong decision, but I don't like that it's a lot more work to
have one binary that both adds plugin features and makes use of new
NetBeans features and still runs on older releases.
I also left the small refactoring in a separate commit, without
squashing the PR so that in the event someone of us overlooked
something it would be trivial to revert.
Tired me yesterday actually kept reading that an existing plugin
failed to run on 16rc1, that is why I said i was wondering why a JVM
would not find that method anymore - which doesn't make any sense in
retrospect.
I'm actually amazed that
"don't think this actually breaks compatibility in a bad away"
seems to be a prevailing direction.
well yes, because compatibility is maintained. Existing code will keep
running. New code can enjoy type safety since runtime CCEs are now
compiler errors. Its unlikely here, but generics can sometimes reveal
bugs.
And since the type is now known it is also better usable in streams,
which is how I noticed that the generics were missing in the first place.
false alarm :)
Not for me
-ernie
-mbien
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
