On Sat, 28 Jan 2023 at 15:19, Łukasz Bownik <lukasz.bow...@gmail.com> wrote: > 1. "we welcome contributions" vs "we want less noise" > 2. "we want small PRs" vs "we want big PRs" > 3. "we want small PRs" vs "we want to save CI resources"
Firstly, we're in the middle of our quarterly release cycle, between feature freeze and release at the moment. That changes things in some ways, due to the use of the delivery branch. Note this from the recent rc2 notice something that causes more hesitation and reflection on merging large PRs - """ PR's with features for a future release : - Base on the master branch. - Will be reviewed and merged in the usual way. - If possible stay away from big refactoring. - If possible do not overlap with fixes for 17 (delivery will be merged to master weekly). """ Secondly, large cleanup PRs can be quicker to produce than review. Again, review time is finite, particularly with the release process happening. And cleanup is going to be lower down the priority list for review than release issues for NB17 or new features for NB18. > 8. "we welcome new contributors" vs "we want high value/impact PRs from day > one" This page used to be linked on the main GitHub page, but they seem to have moved it in the UI - we should probably link it from the README so we know where it is! https://github.com/apache/netbeans/contribute We welcome new contributors, and we try to tag issues that should be simple enough for new contributors to get their teeth into and make a real difference quickly. Or for more complex problems, see also https://github.com/apache/netbeans/issues?q=is%3Aopen+is%3Aissue+label%3A%22Contribution+welcome%22 I'd rather review a small PR with high value that addresses any of those issues any day! > So I think it might be a good idea for the core theme to sit, discuss and > create a document ironing out these issues and laying a general process > that should be followed by contributors. The above links, and other guidance linked from them are intended to do that. Some things are outdated or need highlighting elsewhere. Want another simple, high-value contribution you could make? Help with making that documentation work better so the information is simpler, up-to-date, and easier to find for the next person. Lastly, we're a bunch of diverse people with different backgrounds, opinions, approaches, goals and ways of working. It's open-source - inconsistencies go with the territory! :-) Best wishes, Neil --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@netbeans.apache.org For additional commands, e-mail: dev-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
