Hi,

In order for org.netbeans.modules.ide.ergonomics.DynamicVerifyTest to pass the commit validation test, one has to add ProjectFactories in the test itself, as in [1].

This works fine if the ProjectFactory is included in the cluster configuration ("full" for instance) but makes the test fail if the ProjectFactory is not included in the cluster ("release" for instance).

I think we should make DynamicVerifyTest know which ProjectFactory's to test depending on the cluster configuration. I give it a run during this weekend.

Also we should check that -Dcluster.config=release is still working properly to see if any other tests depend on the cluster configuration.

Cheers,
Antonio


[1]
https://github.com/apache/netbeans/blob/a74f83d37ad54370274c56f7435bc32601188a42/ergonomics/ide.ergonomics/test/unit/src/org/netbeans/modules/ide/ergonomics/DynamicVerifyTest.java#L148

On 26/2/23 22:15, Michael Bien wrote:
Hi Antonio,

this draft tests switching CI from release to the full cluster config.

https://github.com/apache/netbeans/pull/5568

the properties file does need some cleanup IMO and we should make sure that the cluster order isn't significantly different from whatever ends up running during CI and the release config.

best regards,
michael

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists



Reply via email to