Hello devs,

we decided to merge https://github.com/apache/netbeans/pull/5617 which disables the squash feature on github since it caused too many problems.

Please squash your PRs locally before merge. It gives predictable results and makes it less likely to forget squashing if it is part of the normal workflow.

Reviewers are also encouraged to use the needs-squashing label if needed, it is part of the merge/approval checklist [1].

A tip: I often add .patch to the PR url as last check before merge, this will show a formatted patch file, with all author information, commits etc. This is exactly what will land on the target branch post merge.

best regards,

-mbien

[1] https://cwiki.apache.org/confluence/display/NETBEANS/PRs+and+You+-+A+reviewer+Guide


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists



Reply via email to