sorry I should have approved the revert PR earlier, when the other PR
was closed i made a mental "resolved" note and kinda forgot that the
revert PR was still open.
-mbien
On 19.08.24 20:46, Matthias Bläsing wrote:
Hi all,
there is still need for a review on the revert PR. Would be great if
anyone could do it, so that it becomes part of next RC.
Thank you
Matthias
Am Donnerstag, dem 08.08.2024 um 22:37 +0200 schrieb Matthias Bläsing:
Hi,
as last time pinging on github was too silent I try it here. For NB23
issue report #7647 was opened (duplicate warning messages) and it led
to #7579 "Using LSP's ErrorProvider & another attempt at
CompletionCollector". The latter introduced a bridge, that converts LSP
ErrorProvider data to NetBeans Hint data.
In review of #7647 a similar problem was observed with the JavaError
Provider, that doubled error messages for Java.
The fix for the JavaErrorProvider was to remove its registration in the
`java.hints` module and move it to the `java.lsp.server` module. For
some of the other affected ErrorProviders that might to, but there is
also generic support in the csl.api module, that will add an LSP
ErrorProvider for each CSL based language, that offers a HintProvider.
Given this complex situation I prepared a revert PR:
https://github.com/apache/netbeans/pull/7650
The PR applies cleanly.
If no real fix is provided in time, I suggest to merge that for RC3 and
retry in the NB24 range with a different approach.
Greetings
Matthias
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@netbeans.apache.org
For additional commands, e-mail: dev-h...@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@netbeans.apache.org
For additional commands, e-mail: dev-h...@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@netbeans.apache.org
For additional commands, e-mail: dev-h...@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
