Hi!

i think it would be good if we could avoid version bump PRs like #9726
in future. They were useful for a while since we could migrate to
"javac.release" incrementally and fix issues in a more controlled manner
(there were simply too many modules to fix to consider doing this all at
once) but repo wide bumps are always disrupting the workflow a bit.

Lets introduce a default property which modules inherit unless they
declare a version

the new guideline for setting or not setting javac.release would be:

 - don't set it to a module unless you have a really good reason to do that
    - if you have a reason to set it, leave a short comment why it was set
 - lib wrappers (no src) should set javac.release to the lower bound
bytecode level (in case of multi-release jars)
    - some of it could be automated (and some of it is), but i noticed a
discrepancy between osgi and classic wrappers, so lets set it for now,
we can still remove it
    - might be good to see on what bytecode level a wrapper is just by
looking at the project.properties or module properties window -> doesn't
hurt

-> the default would be set centrally from now on

why this took so long was because NB didn't have a central place for
default properties + it needed to be picked up by editor, the build and
options windows while also accounting for legacy source/target and
making sense of it all. So it required a few PRs to get there. (+ as
mentioned above the repo needed to be ready for that too)

but we are almost there:

https://github.com/apache/netbeans/pull/9323

would introduce the default and once the PR (or equivalent) would make
it into a release, we could also start using it. (right now we can't
since it would set the NB 32 editor to 1.4)

best regards,

michael



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists



Reply via email to