[GitHub] incubator-netbeans pull request #91: [NETBEANS-54] Module Review libs.freema...

[vieiro]

GitHub user vieiro opened a pull request:

    https://github.com/apache/incubator-netbeans/pull/91

    [NETBEANS-54] Module Review libs.freemarker

      - Added maven coordinates to external/binaries_list for freemarker 2.3.19 
(BSD 3?)
      - Added headers to two source files (FreemarkerEngine.java & 
FreemarkerFactory.java) and to one test file.
      - All unit tests passing.
      - Not adding license headers to the following test files (as some tests 
would fail):
        -  ./test/unit/data/golden/GeneratedMethodBody.java
        -  ./test/unit/data/golden/ClassWithoutReplacements.java
        -  ./test/unit/data/golden/GeneratedMethodBody2.java
        -  ./test/unit/data/golden/ForceNoReplacements.java
        -  ./test/unit/data/golden/SimpleReplacements.java
        -  ./test/unit/data/licenseheader.txt
        -  ./test/unit/data/templates/GeneratedMethodBody.java
        -  ./test/unit/data/templates/ClassWithoutReplacements.java
        -  ./test/unit/data/templates/SimpleReplacements.java

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/vieiro/incubator-netbeans 
netbeans-54-module-review-libs.freemarker

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-netbeans/pull/91.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #91
    
----
commit ed9232dc8a05aa17123914fcb550efa72eefa2d9
Author: Antonio Vieiro <anto...@vieiro.net>
Date:   2017-10-08T06:33:35Z

    [NETBEANS-54] Module Review libs.freemarker
    
      - Added maven coordinates to external/binaries_list for freemarker 2.3.19 
(BSD 3?)
      - Added headers to two source files (FreemarkerEngine.java & 
FreemarkerFactory.java) and to one test file.
      - All unit tests passing.
      - Not adding license headers to the following test files (as some tests 
would fail):
        -  ./test/unit/data/golden/GeneratedMethodBody.java
        -  ./test/unit/data/golden/ClassWithoutReplacements.java
        -  ./test/unit/data/golden/GeneratedMethodBody2.java
        -  ./test/unit/data/golden/ForceNoReplacements.java
        -  ./test/unit/data/golden/SimpleReplacements.java
        -  ./test/unit/data/licenseheader.txt
        -  ./test/unit/data/templates/GeneratedMethodBody.java
        -  ./test/unit/data/templates/ClassWithoutReplacements.java
        -  ./test/unit/data/templates/SimpleReplacements.java

----


---