Arghh ! Sorry, Junichi, I didn't see that. Wasted work on my part. :-(
Our approaches are different, though. I'n my mind there isn't a template for a "NetBeans license", but one for ASF projects in general .... which NetBeans project happens to use. With this approach it shows up in "Tools --> Templates --> Licenses" and it can be used just as well for those who use the NetBeans IDE to contribute to Tomcat, Cassandra, Maven, or whatever. I'll see if the two approaches can be merged so that we can get the best of both. Lars On Sun, Jan 14, 2018 at 12:25 PM, Lars Bruun-Hansen <lbruunhan...@gmail.com> wrote: > https://github.com/apache/incubator-netbeans/pull/367 > > The new PR simply adds the license header for usage from within the IDE. > It doesn't mean it will actually be used in any project automatically, > which is to say it doesn't in itself help NB contributors to always > remember the correct header on new files. See comments in the PR. The > license header for new files should be a *global* project property for the > Apache NetBeans project, but I don't know how to accomplish this. > > On Sun, Jan 14, 2018 at 10:38 AM, Antonio <anto...@vieiro.net> wrote: > >> Thanks Lars, I've add this requirement to the contributor guidelines. >> >> Regarding the license template for ASF header I think it's a great idea. >> >> Have a good sunday, >> Antonio >> >> >> On 14/01/18 10:17, Lars Bruun-Hansen wrote: >> >>> You are absolute right. Said contribution is using the standard AL v2 >>> license, not the ASF license header. Incorrect, but it is very easy to >>> confuse the two. The latter is a special case of the former. Pull >>> Requests >>> are indeed "developed at the ASF" unless they contain third party code, >>> so >>> PRs must be using the ASF license header, not the AL v2 license header. >>> >>> I think the distinction could be made clearer if the IDE itself had a >>> license template for ASF license header. It doesn't at the moment. >>> Should I >>> create a PR for it? >>> >>> /Lars >>> >>> On Sun, Jan 14, 2018 at 7:22 AM, Antonio <anto...@vieiro.net> wrote: >>> >>> Hi, >>>> >>>> AFAIU all code submitted by contributors must include the standard >>>> license >>>> headers at [1]. So, for instance, headers like [2] are wrong. >>>> >>>> Is this so? >>>> >>>> Thanks, >>>> Antonio >>>> >>>> >>>> [1] >>>> http://www.apache.org/legal/src-headers.html >>>> >>>> [2] >>>> https://github.com/apache/incubator-netbeans/pull/364/commit >>>> s/a114ef12bf32d59d1a80bc504c188aa0afe0c69d >>>> >>>> --------------------------------------------------------------------- >>>> To unsubscribe, e-mail: dev-unsubscr...@netbeans.incubator.apache.org >>>> For additional commands, e-mail: dev-h...@netbeans.incubator.apache.org >>>> >>>> For further information about the NetBeans mailing lists, visit: >>>> https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists >>>> >>>> >>>> >>>> >>>> >>> >> --------------------------------------------------------------------- >> To unsubscribe, e-mail: dev-unsubscr...@netbeans.incubator.apache.org >> For additional commands, e-mail: dev-h...@netbeans.incubator.apache.org >> >> For further information about the NetBeans mailing lists, visit: >> https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists >> >> >> >> >
