@Matthias as requested, I have opened NETBEANS-1803[1], I agree its not blocking the release, so will vote now.
[1]: https://issues.apache.org/jira/browse/NETBEANS-1803 John On Tue, 18 Dec 2018 at 17:26, John McDonnell <mcdonnell.j...@gmail.com> wrote: > Cool, > > I'll try to raise an idea when I get home tonight but other than that I > didnt see any other issues with the release... so I'll vote tonight after I > create the issues... > > John > > On Tue, 18 Dec 2018 at 13:12, Matthias Bläsing <mblaes...@doppel-helix.eu> > wrote: > >> The following is from memory (will not be back to notebook till tomorrow >> night). >> >> Point 1: The .java file is ALv2, but not donated to the Apache foundation >> (adapted from Idea if I recall correctly). We need the licenseinfo.xml for >> the notice file, but could suppress ALv2 output in license generation. An >> issue would be good to track that. Feel free to assign it to me, from my >> POV this should not block release though. >> >> Point 2: the entries are foot notes for the table directly above them. >> >> Am 18. Dezember 2018 11:51:47 MEZ schrieb Geertjan Wielenga >> <geertjan.wiele...@googlemail.com.INVALID>: >> >Thanks a lot for starting this discussion thread. >> > >> >For these two items mentioned I’d recommend just filing issues, they’re >> >minor IMHO though great in the sense that they indicate everything else >> >is >> >in a good state. >> > >> >Gj >> > >> >On Tuesday, December 18, 2018, John McDonnell >> ><mcdonnell.j...@gmail.com> >> >wrote: >> > >> >> Hi, >> >> >> >> Kicking off a Discussion thread for the new vote thread :) >> >> >> >> When Im checking the Licence file I noticed 2 possible issues: >> >> 1. Near the end of the file it has: >> >> platform/o.n.swing.plaf/src/org/netbeans/swing/plaf/util/ >> >> SmoothScrollPaneUI.java >> >> Apache-2.0 >> >> If a file is Apache Licensed it shouldnt be contained in this list, >> >> correct? >> >> >> >> 2. At the end of the file it contains: >> >> "Notes >> >> ----- >> >> [ 1] Copyright (c) 2008, 2009 Sun Microsystems. All rights reserved. >> >> >> >> Contributors: >> >> Linda DeMichiel - Java Persistence 2.0, Version 2.0 >> >(October 1, >> >> 2009) >> >> Specification available from >> >http://jcp.org/en/jsr/detail? >> >> id=317 >> >> >> >> [ 2] Copyright (c) 2008 - 2013 Oracle Corporation. All rights >> >reserved. >> >> >> >> Contributors: >> >> Linda DeMichiel - Java Persistence 2.1, Version 2.1 >> >(February >> >> 4, 2013) >> >> Specification available from >> >http://jcp.org/en/jsr/detail? >> >> id=338 >> >> >> >> [ 3] Copyright (c) 1998, 2010 Oracle. All rights reserved. >> >> >> >> Contributors: >> >> dmccann - December 22/2010 - 2.3 - Initial implementation >> >> >> >> " >> >> >> >> Is this correct for the Licence file? >> >> >> >> Other that that I see no issues, I was able to verify the keys, and >> >build >> >> the source, so when I get clarification on those 2 issues I'm willing >> >to >> >> vote. >> >> >> >> Regards >> >> >> >> John >> >> >> >> -- >> Diese Nachricht wurde von meinem Android-Mobiltelefon mit K-9 Mail >> gesendet. > >
