No objections, in fact, applause. :-) Gj
On Monday, January 28, 2019, Pete Whelpton <peedee...@gmail.com> wrote: > No problem :) > > I guessed that parsing text files for the location would need to be > removed, so I have a branch nearly ready for PR that still has two URLs per > Glassfish version: a main location that will follow re-directs, and a > fallback that expects the URL to be correct > > So, for example, NB could first try and download Glassfish from > netbeans.osuosl.org/binaries and fallback to downloading from > download.oracle.com, or vice versa. > > Whilst I was in there, I also noticed that support for downloading & > registering GF5.0 was essentially already implemented, but commented out, > and I believe I've figured out how to add to add download/registering > support for GF4.1.2, so if there are no objections from the community, I > will add that in too. > > HTH, > > > > On Mon, Jan 28, 2019 at 3:49 PM Geertjan Wielenga > <geertjan.wiele...@googlemail.com.invalid> wrote: > > > Thanks for the great work. :-) > > > > Ideally, we wouldn't need to host any special file anywhere, if that can > be > > done, that would be best. > > > > Alternatively, we have this location in Oregon: > > > > http://netbeans.osuosl.org/binaries > > > > See more about the above here: > > https://jaxenter.com/netbeans/towards-building-netbeans-new-home > > > > Any references to java.download.net or download.oracle.com should > ideally > > be replaced with the above. > > > > Hope this helps, > > > > Gj > > > > On Sat, Jan 26, 2019 at 6:42 PM Pete Whelpton <peedee...@gmail.com> > wrote: > > > > > Ok, I figured out what is happening and got Glassfish 4.1.1 to download > > and > > > install via the NB installer :) Now I could use some guidance from the > > > sages here on what they think the best way forward is! What is > happening > > > is: > > > > > > 1) NB first looks for the .txt file for the relevant Glassfish version > on > > > serverplugins.netbeans.org (it will follow redirects to try and find > > it). > > > 2) If NB finds the txt file, it reads the first line, which contains > the > > > directory path for that version of glassfish (see > > > http://serverplugins.netbeans.org/glassfishv3/post71v3-1-2.txt which > is > > > still up!) > > > 2a) The directory path is appended to the hardcoded base URL, > > > http://download.java.net > > > 2b) NB will then try and download the glassfish .zip from this URL > > (but > > > won't follow redirects!) > > > 3) If NB fails to find/parse the .txt file, it will try and download > the > > > .zip from the direct download.java.net link (the one with the > > > ?nbretriever=fallback querystring), but won't follow redirects > > > > > > Because there are now 301 redirects on the download.java.net URLs from > > > http > > > to https, even the fallback was failing. Changing the fallback URL for > > > GF4.1.1. to https meant that it downloaded correctly. > > > > > > So my questions are: > > > > > > a) Do we want to keep this logic, and host .txt files with the download > > > path on netbeans.apache.org? Probably the least intrusive way to get > > > things working again.... > > > b) If not, what to do with this logic? Delete it? comment it out and > > just > > > the fallback URL? or leave it in and allow NB to waste a few cycles > > trying > > > to find a .txt file that doesn't exist? > > > c) Do we want to take this opportunity to update the java.download.net > > > hostname to download.oracle.com, as that seems to be where the main > > > Glassfish web page links to now for downloads? > > > d) Should the fallback URL also follow redirects? > > > > > > Any and all opinions welcome :) > > > > > > HTH > > > > > > P > > > > > > On Fri, Jan 25, 2019 at 11:21 AM Pete Whelpton <peedee...@gmail.com> > > > wrote: > > > > > > > > > > > I'm not 100% sure yet... still working through the downloader code. > > For > > > > each version of Glassfish supported, there is an enum > > > > in > > > > > /enterprise/glassfish.common/src/org/netbeans/modules/glassfish/common/ > ServerDetails.java > > > > that contains among other things two URLS: > > > > > > > > 1) Link to the Glassfish .zip file hosted on download.java.net > > > > 2) Link to one of these .txt files hosted on > > serverplugins.netbeans.org > > > > > > > > E.g. for Glassfish 4.1.1: > > > > > > > > " > > > > > > > > > http://download.java.net/glassfish/4.1.1/release/glassfish-4.1.1.zip? > nbretriever=fallback > > > ", > > > > // NOI18N > > > > "http://serverplugins.netbeans.org/glassfishv3/post71v4-1-1.txt"; // > > > NOI18N > > > > > > > > The download.java.net links still seem to be valid, but the > > > > serverplugins.netbeans.org links aren't. > > > > > > > > It's still a bit of a hunch at the moment, and you are right, we need > > to > > > > figure out how those txt files were used, but given that the > downloader > > > no > > > > longer works in NB8.2 too, I'm thinking it could well be an external > > > > dependency that is broken? > > > > > > > > I'm hoping somebody more experienced than I has an idea what those > txt > > > > files were for? > > > > > > > > > > > > > > > > P > > > > > > > > > > > > On Fri, Jan 25, 2019 at 10:54 AM Geertjan Wielenga > > > > <geertjan.wiele...@googlemail.com.invalid> wrote: > > > > > > > >> How are they needed? I doubt they have been needed or used for a > while > > > >> since they come from Kenai which has not been around for some time. > > > Thanks > > > >> for your great work. > > > >> > > > >> Gj > > > >> > > > >> On Friday, January 25, 2019, Pete Whelpton <peedee...@gmail.com> > > wrote: > > > >> > > > >> > Hi all :) > > > >> > > > > >> > Thought I might have a quick look into these (attempting to > download > > > >> > Glassfish via NB results in "Not Found" error). > > > >> > > > > >> > I think one problem here is that for each supported version of > > > >> Glassfish, > > > >> > there was a related text file on the old netbeans.org: > > > >> > > > > >> > * http://serverplugins.netbeans.org/glassfishv3/post701v3.txt > > > >> > * http://serverplugins.netbeans.org/glassfishv3/post701v3-0-1.txt > > > >> > * http://serverplugins.netbeans.org/glassfishv3/post701v3-1.txt > > > >> > * http://serverplugins.netbeans.org/glassfishv3/post701v3-1-1.txt > > > >> > * http://serverplugins.netbeans.org/glassfishv3/post71v3-1-2.txt > > > >> > * http://serverplugins.netbeans.org/glassfishv3/post71v3-1-2.txt > > > >> > * http://serverplugins.netbeans.org/glassfishv3/post71v4-0.txt > > > >> > * http://serverplugins.netbeans.org/glassfishv3/post71v4-0-1.txt > > > >> > * http://serverplugins.netbeans.org/glassfishv3/post71v4-1.txt > > > >> > * http://serverplugins.netbeans.org/glassfishv3/post71v4-1-1.txt > > > >> > * http://serverplugins.netbeans.org/glassfishv3/post71v5-0.txt > > > >> > > > > >> > Does anybody know: > > > >> > > > > >> > a) what these .txt files are? > > > >> > b) if they made it to a new home on netbeans.apache.org? > > > >> > > > > >> > > > > >> > P > > > >> > > > > >> > > > > > > > > > >
