Github user olegz commented on a diff in the pull request:
https://github.com/apache/nifi/pull/123#discussion_r44873446
--- Diff:
nifi-nar-bundles/nifi-provenance-repository-bundle/nifi-persistent-provenance-repository/src/main/java/org/apache/nifi/provenance/lucene/DocsReader.java
---
@@ -47,9 +46,6 @@
public class DocsReader {
private final Logger logger =
LoggerFactory.getLogger(DocsReader.class);
- public DocsReader(final List<File> storageDirectories) {
- }
-
--- End diff --
I agree that depreciation is the right thing to do in general cases like
this. But given that the project is pre-1.0 and obvious intent of this class
not being a public API I felt removing it would be ok. Still do but will honor
the majority opinion and will deprecate.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
