So, I’ve just pushed initial version to https://github.com/olegz/nifi/tree/int-test Please review and let me know what you think (primarily as to the location and structure of the module)
There is currently one test for Site-to-Site (many others are work in progress), but even with this test you can see comments about periodic failures https://github.com/olegz/nifi/blob/int-test/nifi-integration-tests/src/test/java/org/apache/nifi/test/s2s/SiteToSiteTests.java#L75. Perhaps yet another JIRA to be opened. I didn’t do any Maven profiling (perhaps someone can help) Anyway, LMK. Cheers Oleg On Dec 22, 2015, at 8:25 AM, Joe Skora <[email protected]<mailto:[email protected]>> wrote: This sounds great. Profile activation makes sense. I like the test app idea as well, perhaps we could eventually capture some data from that such as CPU time, memory usage, architecture, etc. to better gather a set of benchmarks and expectations for various components. Would it make sense to also have a profile for each service dependency such as AWS, Hadoop, Kafka, etc.; so that even where only some services are available those tests could still be run? On Mon, Dec 21, 2015 at 4:09 PM, Tony Kurc <[email protected]<mailto:[email protected]>> wrote: I was trying to look through projects that had tests like this.. Rather than the tests being part of the build, they could be standalone apps, maybe like the accumulo continuous ingest tests? Tony On Dec 21, 2015 4:00 PM, "Oleg Zhurakousky" <[email protected]<mailto:[email protected]>> wrote: Correct, and I think my point would be it depends on the individual test, but in any event, let me take a first crack at it and then we can decide. On Dec 21, 2015, at 3:46 PM, Joe Witt <[email protected]<mailto:[email protected]>> wrote: i suspect we're all thinking 'how long will they run and if long let's support profile activation'? On Mon, Dec 21, 2015 at 3:34 PM, Oleg Zhurakousky <[email protected]<mailto:[email protected]>> wrote: Cool, I may need some help with maven, but I’ll push a PR when ready. Also, I don’t see these unit tests any different then any other unit tests. The only difference is that they will test functionality that requires multiple modules (e.g., site-to-site) Oleg On Dec 21, 2015, at 3:28 PM, Joe Witt <[email protected]<mailto:[email protected]>> wrote: profile activated i hope :-) Right under nifi seems fine to me. Thanks Joe On Mon, Dec 21, 2015 at 3:22 PM, Oleg Zhurakousky <[email protected]<mailto:[email protected]>> wrote: Not on github yet. Basically another module right at the root of nifi, hence it will be subject to global build, test etc. Oleg On Dec 21, 2015, at 3:12 PM, Tony Kurc <[email protected]<mailto:[email protected]>> wrote: I certainly am interested in such a thing. How do you see this fitting in the source tree/ build cycle? On Dec 21, 2015 3:07 PM, "Oleg Zhurakousky" < [email protected]<mailto:[email protected]>> wrote: Guys I’ve created a module called nfii-integration-tests. The goal of this module is to facilitate unit testing of things that required collaboration between the modules (e.g., site-to-site) as well as discover potential improvements that could be made to the code base (e.g., NIFI-1318). It helps me quite a bit so I was wondering if there is any interest in adding such module to NiFi? Cheers Oleg
