Joes and Bryan, I was reviewing pr #149 and had to infer what JoeWitt and Bryan were thinking on the issue. Seems like if this becomes a pattern, we should make a strong informed call on where the package goes from the start!
Tony On Wed, Dec 16, 2015 at 11:20 AM, Joe Gresock <[email protected]> wrote: > I added https://issues.apache.org/jira/browse/NIFI-1291 to keep this > going. > > On Sun, Dec 13, 2015 at 10:11 PM, Joe Witt <[email protected]> wrote: > > > This is a great point as that is a non-trivial pattern and one that > > can be reused. I could definitely see value in spinning out a > > nifi-commons module for this (if there isn't already one appropriate > > for it). > > > > On Sun, Dec 13, 2015 at 9:54 PM, Bryan Bende <[email protected]> wrote: > > > Joe, > > > > > > Thanks for bringing this up. I remember running into this issue a long > > time > > > ago when trying to extend BinFiles from a processor in another NAR. > > > > > > I'm wondering if there could be another artifact in > nifi-standard-bundle > > > like nifi-standard-processor-utils where stuff like this could go? > There > > is > > > already a nifi-processor-utils artifact in nifi-commons, but not sure > if > > it > > > makes sense to push an abstract processor all the way back there. > > > > > > Curious what others think. > > > > > > -Bryan > > > > > > On Fri, Dec 11, 2015 at 9:33 PM, Joe Gresock <[email protected]> > wrote: > > > > > >> In NIFI-305, we refactored a parent class for MergeContent so the > > binning > > >> functionality could be reused. In practice, this isn't quite useful > > yet, > > >> because BinFiles is still in the nifi-standard-processors, which > > contains > > >> an org.apache.nifi.processor.Processor file. Therefore, any processor > > that > > >> tries to extend BinFiles must automatically pull in all the processors > > in > > >> nifi-standard-processors, which is probably undesirable if it's an > > >> extension. > > >> > > >> Is there anywhere in the code we could put parent classes like this > for > > >> extensibility purposes? > > >> > > >> Thanks, > > >> Joe > > >> > > >> -- > > >> I know what it is to be in need, and I know what it is to have plenty. > > I > > >> have learned the secret of being content in any and every situation, > > >> whether well fed or hungry, whether living in plenty or in want. I > can > > do > > >> all this through him who gives me strength. *-Philippians 4:12-13* > > >> > > > > > > -- > I know what it is to be in need, and I know what it is to have plenty. I > have learned the secret of being content in any and every situation, > whether well fed or hungry, whether living in plenty or in want. I can do > all this through him who gives me strength. *-Philippians 4:12-13* >
