Github user joewitt commented on a diff in the pull request:
https://github.com/apache/nifi/pull/135#discussion_r48701229
--- Diff:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/SplitText.java
---
@@ -82,10 +84,16 @@
public static final PropertyDescriptor LINE_SPLIT_COUNT = new
PropertyDescriptor.Builder()
.name("Line Split Count")
- .description("The number of lines that will be added to each
split file")
+ .description("The number of lines that will be added to each
split file, excluding header lines")
.required(true)
.addValidator(StandardValidators.POSITIVE_INTEGER_VALIDATOR)
.build();
+ public static final PropertyDescriptor FRAGMENT_MAX_SIZE = new
PropertyDescriptor.Builder()
+ .name("Maximum Fragment Size")
+ .description("The maximum size of each split file, including
header lines")
--- End diff --
Seems like there could be some interesting edge conditions. For instance
what if a given line is by itself larger than the max? Or, does the max get
exceeded by the size of at most one line then split or is the max exceeded then
a pushback mechanism goes to the previous line and does the split and then
continues? I might be overthinking this but in any case would be good to let
the user know how these edge cases are handled.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
