Github user olegz commented on a diff in the pull request:

    https://github.com/apache/nifi/pull/163#discussion_r49476661
  
    --- Diff: 
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/util/PGPUtil.java
 ---
    @@ -0,0 +1,89 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +package org.apache.nifi.processors.standard.util;
    +
    +import org.apache.nifi.processors.standard.EncryptContent;
    +import org.bouncycastle.bcpg.ArmoredOutputStream;
    +import org.bouncycastle.openpgp.PGPCompressedData;
    +import org.bouncycastle.openpgp.PGPCompressedDataGenerator;
    +import org.bouncycastle.openpgp.PGPEncryptedData;
    +import org.bouncycastle.openpgp.PGPEncryptedDataGenerator;
    +import org.bouncycastle.openpgp.PGPException;
    +import org.bouncycastle.openpgp.PGPLiteralData;
    +import org.bouncycastle.openpgp.PGPLiteralDataGenerator;
    +import org.bouncycastle.openpgp.operator.PGPKeyEncryptionMethodGenerator;
    +import org.bouncycastle.openpgp.operator.jcajce.JcePGPDataEncryptorBuilder;
    +import org.slf4j.Logger;
    +import org.slf4j.LoggerFactory;
    +
    +import java.io.IOException;
    +import java.io.InputStream;
    +import java.io.OutputStream;
    +import java.security.SecureRandom;
    +import java.util.Date;
    +import java.util.zip.Deflater;
    +
    +/**
    + * This class contains static utility methods to assist with common PGP 
operations.
    + */
    +public class PGPUtil {
    +    private static final Logger logger = 
LoggerFactory.getLogger(PGPUtil.class);
    +
    +    public static final int BUFFER_SIZE = 65536;
    +    public static final int BLOCK_SIZE = 4096;
    +
    +    public static void encrypt(InputStream in, OutputStream out, String 
algorithm, String provider, int cipher, String filename, 
PGPKeyEncryptionMethodGenerator encryptionMethodGenerator) throws IOException, 
PGPException {
    +        final boolean isArmored = 
EncryptContent.isPGPArmoredAlgorithm(algorithm);
    --- End diff --
    
    Given that this is a public method I'd suggest to do a null check for 
"algorithm" to avoid NPE in EncryptContent. . .


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to