Github user joewitt commented on the pull request:
https://github.com/apache/nifi/pull/186#issuecomment-174512618
Hello
The community is working toward closing down on the 050 release so PR
review bandwidth is limited right now. This PR represents a pretty significant
step towards integration with another framework so we need to be thoughtful
about the user experience. So while this represents a very interesting and
compelling integration it may take a bit of time to get right.
Now the PR as-is there are a few quick items I've noticed.
* It still appears the license and notice information included is
copy/paste from the Flume nar as originally identified. Those are very
important to to get right.
* There does not appear to be any tests.
* Documentation on the approach, idea, and processor is very limited.
There is a sentence about it on the JIRA but it would be really helpful to
understand more about the idea and how it compliments NiFi and Camel. Users
and developers will definitely want to know this.
* There is a declaration of ThreadLocal usage and then the use of it
appears commented out. This will need to be removed.
* There is use of e.printStackStrack() and this needs to be using the
provided processor Logger.
* A camel application context is provided in src/resources but it appears
it should be a test resource
Very much appreciate the contribution and effort. Just need your
understanding that things this important take time and a lot of diligence.
Thanks
Joe
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
