Github user olegz commented on a diff in the pull request:
https://github.com/apache/nifi/pull/221#discussion_r54095802
--- Diff:
nifi-commons/nifi-processor-utilities/src/main/java/org/apache/nifi/processor/util/bin/Bin.java
---
@@ -121,8 +125,9 @@ public boolean offer(final FlowFile flowFile, final
ProcessSession session) {
final String countValue =
flowFile.getAttribute(fileCountAttribute);
final Integer count = toInteger(countValue);
if (count != null) {
- this.maximumEntries = Math.min(count, this.maximumEntries);
- this.minimumEntries = this.maximumEntries;
+ int currentMaxEntries = this.maximumEntries;
+ this.maximumEntries = Math.min(count, currentMaxEntries);
+ this.minimumEntries = currentMaxEntries;
--- End diff --
Not sure why it was necessary (other then style), but overall PR looks good.
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
