Github user jvwing commented on the pull request:
https://github.com/apache/nifi/pull/224#issuecomment-189425709
I stand corrected. The non-integration unit tests are importing
CREDENTIALS_FILE from ITAbstractDynamoDBTest, although the integration test
itself may not be called.
But I think the unit tests run by TravisCI should pass. Either the tests
requiring a file in the user's home folder are truly integration tests and need
to be marked as such, or the file needs to get checked in to git. I believe
you have checked in a similar test credentials file while working on the
AWSCredentialsProviderControllerService, and that seemed to work just fine.
It's also possible that the unit tests do not need a credentials file at
all, since they won't make API calls to AWS. Can't we just remove it from the
tests?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
