Github user olegz commented on a diff in the pull request:
https://github.com/apache/nifi/pull/248#discussion_r54298253
--- Diff:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/UnpackContent.java
---
@@ -202,11 +213,11 @@ public void onTrigger(final ProcessContext context,
final ProcessSession session
final boolean addFragmentAttrs;
switch (packagingFormat) {
case TAR_FORMAT:
--- End diff --
Have you considered doing some restructuring of the _onTrigger()_ method?
Since the packaging format is based on the processor wide configuration
property (not FlowFile) most of the logic (switch/case) could be performed once
instead of every time _onTrigger()_ is called. That includes the new logic with
regex pattern compile.
Or am I missing something big here?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
