Github user apiri commented on a diff in the pull request: https://github.com/apache/nifi/pull/224#discussion_r56242141 --- Diff: nifi-nar-bundles/nifi-aws-bundle/nifi-aws-processors/src/main/java/org/apache/nifi/processors/aws/dynamodb/AbstractDynamoDBProcessor.java --- @@ -0,0 +1,337 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.nifi.processors.aws.dynamodb; + +import java.math.BigDecimal; +import java.nio.charset.Charset; +import java.util.ArrayList; +import java.util.Arrays; +import java.util.Collections; +import java.util.HashMap; +import java.util.HashSet; +import java.util.List; +import java.util.Map; +import java.util.Set; + +import org.apache.commons.lang3.StringUtils; +import org.apache.nifi.components.AllowableValue; +import org.apache.nifi.components.PropertyDescriptor; +import org.apache.nifi.flowfile.FlowFile; +import org.apache.nifi.processor.ProcessContext; +import org.apache.nifi.processor.ProcessSession; +import org.apache.nifi.processor.Relationship; +import org.apache.nifi.processor.util.StandardValidators; +import org.apache.nifi.processors.aws.AbstractAWSCredentialsProviderProcessor; + +import com.amazonaws.AmazonClientException; +import com.amazonaws.AmazonServiceException; +import com.amazonaws.ClientConfiguration; +import com.amazonaws.auth.AWSCredentials; +import com.amazonaws.auth.AWSCredentialsProvider; +import com.amazonaws.services.dynamodbv2.AmazonDynamoDBClient; +import com.amazonaws.services.dynamodbv2.document.DynamoDB; +import com.amazonaws.services.dynamodbv2.model.AttributeValue; + +/** + * Base class for Nifi dynamo db related processors + * + * @see DeleteDynamoDB + * @see PutDynamoDB + * @see GetDynamoDB + */ +public abstract class AbstractDynamoDBProcessor extends AbstractAWSCredentialsProviderProcessor<AmazonDynamoDBClient> { + + public static final Relationship REL_UNPROCESSED = new Relationship.Builder().name("unprocessed") + .description("FlowFiles are routed to unprocessed relationship when DynamoDB is not able to process " + + "all the items in the request. Typical reasons are insufficient table throughput capacity and exceeding the maximum bytes per request. " + + "Unprocessed FlowFiles can be retried with a new request.").build(); + + public static final AllowableValue ALLOWABLE_VALUE_STRING = new AllowableValue("string"); + public static final AllowableValue ALLOWABLE_VALUE_NUMBER = new AllowableValue("number"); + + public static final String DYNAMODB_KEY_ERROR_UNPROCESSED = "dynamodb.key.error.unprocessed"; + public static final String DYNAMODB_RANGE_KEY_VALUE_ERROR = "dynmodb.range.key.value.error"; + public static final String DYNAMODB_HASH_KEY_VALUE_ERROR = "dynmodb.hash.key.value.error"; + public static final String DYNAMODB_KEY_ERROR_NOT_FOUND = "dynamodb.key.error.not.found"; + public static final String DYNAMODB_ERROR_EXCEPTION_MESSAGE = "dynamodb.error.exception.message"; + public static final String DYNAMODB_ERROR_CODE = "dynamodb.error.code"; + public static final String DYNAMODB_ERROR_MESSAGE = "dynamodb.error.message"; + public static final String DYNAMODB_ERROR_TYPE = "dynamodb.error.type"; + public static final String DYNAMODB_ERROR_SERVICE = "dynamodb.error.service"; + public static final String DYNAMODB_ERROR_RETRYABLE = "dynamodb.error.retryable"; + public static final String DYNAMODB_ERROR_REQUEST_ID = "dynamodb.error.request.id"; + public static final String DYNAMODB_ERROR_STATUS_CODE = "dynamodb.error.status.code"; + public static final String DYNAMODB_ITEM_HASH_KEY_VALUE = " dynamodb.item.hash.key.value"; + public static final String DYNAMODB_ITEM_RANGE_KEY_VALUE = " dynamodb.item.range.key.value"; + public static final String DYNAMODB_ITEM_IO_ERROR = "dynamodb.item.io.error"; + + protected static final String DYNAMODB_KEY_ERROR_NOT_FOUND_MESSAGE = "DynamoDB key not found : "; + + public static final PropertyDescriptor TABLE = new PropertyDescriptor.Builder() + .name("Table Name") + .required(true) + .expressionLanguageSupported(false) + .addValidator(StandardValidators.NON_EMPTY_VALIDATOR) + .description("The DynamoDB table name") + .build(); + + public static final PropertyDescriptor HASH_KEY_VALUE = new PropertyDescriptor.Builder() + .name("Hash Key Value") + .required(true) + .expressionLanguageSupported(true) + .addValidator(StandardValidators.NON_EMPTY_VALIDATOR) + .description("The hash key value of the item") + .defaultValue("${dynamodb.item.hash.key.value}") + .build(); + + public static final PropertyDescriptor RANGE_KEY_VALUE = new PropertyDescriptor.Builder() + .name("Range Key Value") + .required(false) + .addValidator(StandardValidators.NON_EMPTY_VALIDATOR) + .expressionLanguageSupported(true) --- End diff -- Is there a reason why only this property supports EL? Seems like there are others that are similar in nature that would also benefit. Not overly familiar with DynamoDB, so please let me know any details.
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---