Github user joewitt commented on a diff in the pull request:

    https://github.com/apache/nifi/pull/285#discussion_r56418107
  
    --- Diff: 
nifi-api/src/main/java/org/apache/nifi/processor/AbstractProcessor.java ---
    @@ -27,7 +30,12 @@ public final void onTrigger(final ProcessContext 
context, final ProcessSessionFa
                 onTrigger(context, session);
                 session.commit();
             } catch (final Throwable t) {
    -            getLogger().error("{} failed to process due to {}; rolling 
back session", new Object[]{this, t});
    +            StringWriter stacktraceWriter = new StringWriter();
    --- End diff --
    
    This logic needs to be in the logger and that is its intent.  You will note 
that the throwable is being passed into it.  The stack traces are getting 
logged when debug level is engaged for a given logger.  This allows the user to 
control whether they are generated or not.  That said...it is clearly 
counterintuitive and we need to improve.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to