Sounds good to here as well. Given the increasing number of contributions, which predominantly seem to arrive via GitHub PR, I also created NIFI-1615 [1] a little while ago to make a GitHub PR template [1]. Would like to distill the contributor guide down into a few easy steps for folks to check out and make apprised of before they commit the PR that I think can help our reviewers and infrastructure.
[1] https://issues.apache.org/jira/browse/NIFI-1615 [2] https://github.com/blog/2111-issue-and-pull-request-templates On Thu, Mar 17, 2016 at 9:55 PM, Oleg Zhurakousky < ozhurakou...@hortonworks.com> wrote: > +1 here as well > My apologies Tony > > Sent from my iPhone > > > On Mar 17, 2016, at 21:42, Joe Witt <joe.w...@gmail.com> wrote: > > > > +1 > > > >> On Thu, Mar 17, 2016 at 9:37 PM, Tony Kurc <trk...@gmail.com> wrote: > >> As I was reviewing a pull request, i realized that it actually was a bit > >> more mental effort in this instance to review a squashed and rebased > set of > >> commits than if it was if I could just review the changes in a commit. > Does > >> anyone object to me adding in the contributors guide something to the > >> extent of "Although you may be asked to rebase or squash your > contribution > >> as part of the review process, don't feel the need to do so > speculatively. > >> The committer working on merging the contribution may prefer to do these > >> types of operations as part of the merge process, and the history of > your > >> patch or pull request may aid in the review process" > >> > >> Tony > > >
