Github user olegz commented on the pull request:
https://github.com/apache/nifi/pull/305#issuecomment-202872584
@steveyh25
I am ok with NFE. Actually if you do some research it appears to behave a
bit better then other approaches that may look better on the surface. I've
added a small comment, otherwise it looks good. The only thing I'd like to ask
is to add some tests (to validate both success and failure) conditions. Even
the test that you modified originally just add assertions that those properties
were indeed set since that is the logic that was modified.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
