Github user jvwing commented on the pull request:

    https://github.com/apache/nifi/pull/334#issuecomment-207841740
  
    @Hejki, this looks like a solid fix to me.  One thing I suggest you add is 
some unit tests, which I missed when I "fixed" this a couple months ago.  If 
that sounds like overkill for such a simple change, well... I use to agree :).
    
    I made some [sample tests to verify your 
fix](https://github.com/jvwing/nifi/commit/004ca21e50dd4f4c98923dbb9a49528ad8544179),
 you are welcome to use them.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to