Github user olegz commented on a diff in the pull request:
https://github.com/apache/nifi/pull/338#discussion_r60088663
--- Diff:
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-cluster/src/main/java/org/apache/nifi/cluster/coordination/http/endpoints/ControllerServicesEndpointMerger.java
---
@@ -0,0 +1,56 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.nifi.cluster.coordination.http.endpoints;
+
+import java.net.URI;
+import java.util.Map;
+import java.util.Set;
+
+import org.apache.nifi.cluster.manager.NodeResponse;
+import org.apache.nifi.cluster.protocol.NodeIdentifier;
+import org.apache.nifi.web.api.dto.ControllerServiceDTO;
+import org.apache.nifi.web.api.entity.ControllerServicesEntity;
+
+public class ControllerServicesEndpointMerger extends
AbstractMultiEntityEndpoint<ControllerServicesEntity, ControllerServiceDTO> {
+ public static final String CONTROLLER_SERVICES_URI =
"/nifi-api/controller/controller-services/node";
+
+ @Override
+ public boolean canHandle(URI uri, String method) {
+ return "GET".equalsIgnoreCase(method) &&
CONTROLLER_SERVICES_URI.equals(uri.getPath());
+ }
+
+ @Override
+ protected Class<ControllerServicesEntity> getEntityClass() {
+ return ControllerServicesEntity.class;
+ }
+
+ @Override
+ protected Set<ControllerServiceDTO> getDtos(ControllerServicesEntity
entity) {
+ return entity.getControllerServices();
+ }
+
+ @Override
+ protected String getComponentId(ControllerServiceDTO dto) {
+ return dto.getId();
+ }
--- End diff --
Not sure about the design considerations, must be missing something. . .,
but the two methods above seem to be simply delegating to public accessors of
the instance passed as an argument (e.g., dto.getId(),
entity.getControllerServices() etc.). Since the calling class obviously has a
reference to such instance, it could invoke those operations directly. Correct?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
