Github user olegz commented on a diff in the pull request:
https://github.com/apache/nifi/pull/354#discussion_r60167411
--- Diff:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/TransformJSON.java
---
@@ -0,0 +1,211 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.nifi.processors.standard;
+
+
+import java.io.IOException;
+import java.io.InputStream;
+import java.io.OutputStream;
+import java.util.ArrayList;
+import java.util.Collections;
+import java.util.HashSet;
+import java.util.List;
+import java.util.Set;
+import java.util.concurrent.TimeUnit;
+
+import org.apache.nifi.annotation.behavior.EventDriven;
+import org.apache.nifi.annotation.behavior.InputRequirement;
+import org.apache.nifi.annotation.behavior.SideEffectFree;
+import org.apache.nifi.annotation.behavior.SupportsBatching;
+import org.apache.nifi.annotation.documentation.CapabilityDescription;
+import org.apache.nifi.annotation.documentation.Tags;
+import org.apache.nifi.annotation.lifecycle.OnScheduled;
+import org.apache.nifi.components.AllowableValue;
+import org.apache.nifi.components.PropertyDescriptor;
+import org.apache.nifi.components.ValidationContext;
+import org.apache.nifi.components.ValidationResult;
+import org.apache.nifi.components.Validator;
+import org.apache.nifi.flowfile.FlowFile;
+import org.apache.nifi.logging.ProcessorLog;
+import org.apache.nifi.processor.AbstractProcessor;
+import org.apache.nifi.processor.ProcessContext;
+import org.apache.nifi.processor.ProcessSession;
+import org.apache.nifi.processor.Relationship;
+import org.apache.nifi.processor.exception.ProcessException;
+import org.apache.nifi.processor.io.StreamCallback;
+import org.apache.nifi.processor.util.StandardValidators;
+import org.apache.nifi.stream.io.BufferedInputStream;
+import org.apache.nifi.util.StopWatch;
+
+import com.bazaarvoice.jolt.Shiftr;
+import com.bazaarvoice.jolt.Removr;
+import com.bazaarvoice.jolt.Chainr;
+import com.bazaarvoice.jolt.Defaultr;
+import com.bazaarvoice.jolt.Transform;
+import com.bazaarvoice.jolt.JsonUtils;
+
+@EventDriven
+@SideEffectFree
+@SupportsBatching
+@Tags({"json", "jolt", "transform", "shiftr", "chainr", "defaultr",
"removr"})
+@InputRequirement(InputRequirement.Requirement.INPUT_REQUIRED)
+@CapabilityDescription("Applies a list of JOLT specifications to the
flowfile JSON payload. A new FlowFile is created "
+ + "with transformed content and is routed to the 'success'
relationship. If the JSON transform "
+ + "fails, the original FlowFile is routed to the 'failure'
relationship")
+public class TransformJSON extends AbstractProcessor {
+
+ public static final AllowableValue SHIFTR = new
AllowableValue("Shift", "Shift Transform DSL", "This JOLT transformation will
shift input JSON/data to create the output JSON/data.");
+ public static final AllowableValue CHAINR = new
AllowableValue("Chain", "Chain Transform DSL", "Execute list of JOLT
transformations.");
+ public static final AllowableValue DEFAULTR = new
AllowableValue("Default", "Default Transform DSL", " This JOLT transformation
will apply default values to the output JSON/data.");
+ public static final AllowableValue REMOVR = new
AllowableValue("Remove", "Remove Transform DSL", " This JOLT transformation
will apply default values to the output JSON/data.");
+
+ public static final PropertyDescriptor JOLT_SPEC = new
PropertyDescriptor.Builder()
+ .name("Jolt Specification")
--- End diff --
Something @alopresto pointed out on another unrelated PR, yet a valid point
and we need to start making it as a rule and that is using _name_ and
_displayName_. In fact I'll quote Andy's comment:
".name should be a machine-safe string (i.e. ssl-context-service) which
will remain constant over the life of the processor because it is used for
object resolution when loading from the flow.tar.gz file. For the
human-readable value to display in the UI, please use .displayName. This can be
changed without affecting object resolution (for future renaming,
internationalization, etc.)."
So, you can name the above property "jolt-spec" or something like that, yet
keep _displayName_ "Jolt Specification". The benefit if at some point we find a
more user friendly name we'll be able to change it at will, which is not
something we'll be able to do with the current approach.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
