Github user alopresto commented on a diff in the pull request:
https://github.com/apache/nifi/pull/387#discussion_r63269309
--- Diff:
nifi-nar-bundles/nifi-scripting-bundle/nifi-scripting-processors/src/main/java/org/apache/nifi/processors/script/AbstractScriptProcessor.java
---
@@ -216,7 +220,8 @@ public void setup() {
*
* @see org.apache.nifi.processors.script.ScriptEngineConfigurator
*/
- protected void setupEngine() {
+ protected void setupEngines(int numberOfScriptEngines) {
+ engineQ = new LinkedBlockingQueue<>(numberOfScriptEngines);
ClassLoader originalContextClassLoader =
Thread.currentThread().getContextClassLoader();
try {
ProcessorLog log = getLogger();
--- End diff --
GitHub won't let me put the line comment on 229, but that can throw an NPE
if the `scriptEngineName` is not defined when this method is run. In normal
execution, that won't occur, but during test configuration, the `setup` method
can be called before the `context` is defined and provided.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
