Github user markap14 commented on a diff in the pull request:

    https://github.com/apache/nifi/pull/461#discussion_r64248276
  
    --- Diff: 
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-core/src/main/java/org/apache/nifi/groups/StandardProcessGroup.java
 ---
    @@ -283,38 +283,21 @@ public boolean isRootGroup() {
         public void startProcessing() {
             readLock.lock();
             try {
    -            for (final ProcessorNode node : processors.values()) {
    +            
findAllProcessors().stream().filter(SCHEDULABLE_PROCESSORS).forEach(node -> {
    --- End diff --
    
    It seems like here, rather than finding all processors and putting them 
into a set, then converting to a stream and filtering, we should allow a 
Predicate to be passed into the findAllProcessors() method? Same for 
input/output ports


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to