Github user olegz commented on a diff in the pull request:

    https://github.com/apache/nifi/pull/511#discussion_r67156509
  
    --- Diff: 
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/main/java/org/apache/nifi/web/StandardNiFiWebConfigurationContext.java
 ---
    @@ -452,8 +456,40 @@ private ComponentDetails 
getComponentConfiguration(final ProcessorDTO processor)
                         .state(processor.getState())
                         .annotationData(processorConfig.getAnnotationData())
                         .properties(processorConfig.getProperties())
    +                    .descriptors(getComponentDescriptors(processorConfig))
                         
.validateErrors(processor.getValidationErrors()).build();
             }
    +
    +        private Map<String,ComponentDescriptor> 
getComponentDescriptors(final ProcessorConfigDTO processorConfig){
    --- End diff --
    
    Do you think it would be more appropriate to name the operation 
_buildComponentDescriptors(..)_ instead of _get*_?
    IMHO _get*_ usually implies an operation that is returning something that 
already exist. Your call, but wanted to share.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to