Github user JPercivall commented on a diff in the pull request:

    https://github.com/apache/nifi/pull/542#discussion_r67714535
  
    --- Diff: 
nifi-nar-bundles/nifi-hbase-bundle/nifi-hbase-processors/src/main/java/org/apache/nifi/hbase/PutHBaseJSON.java
 ---
    @@ -89,6 +89,25 @@
                 .defaultValue(COMPLEX_FIELD_TEXT.getValue())
                 .build();
     
    +    protected static final String STRING_ENCODING_VALUE = "String";
    +    protected static final String BYTES_ENCODING_VALUE = "Bytes";
    +
    +    protected static final AllowableValue FIELD_ENCODING_STRING = new 
AllowableValue(STRING_ENCODING_VALUE, STRING_ENCODING_VALUE,
    +            "Stores the value of each field as a UTF-8 String.");
    --- End diff --
    
    Secondly, will users configuring this processor know what a "String" is 
(aka. is it a concept that is used regularly when configuring HBase)?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to