Github user alopresto commented on a diff in the pull request:

    https://github.com/apache/nifi/pull/541#discussion_r67738328
  
    --- Diff: 
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-core/src/main/java/org/apache/nifi/controller/service/StandardControllerServiceProvider.java
 ---
    @@ -70,7 +67,7 @@
     
         private final ProcessScheduler processScheduler;
         private static final Set<Method> validDisabledMethods;
    -    private final BulletinRepository bulletinRepo;
    +    // private final BulletinRepository bulletinRepo;
    --- End diff --
    
    I removed the two commented lines (the declaration and the assignment in 
the constructor). However, I did not change the constructor contract, as it is 
used 17 times throughout the application. @mcgilman @markap14 is the bulletin 
repository work going to have additional impact, or is it safe to clean up this 
constructor universally?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to