Github user mattyb149 commented on a diff in the pull request:

    https://github.com/apache/nifi/pull/534#discussion_r67970007
  
    --- Diff: 
nifi-nar-bundles/nifi-scripting-bundle/nifi-scripting-processors/src/main/java/org/apache/nifi/processors/script/InvokeScriptedProcessor.java
 ---
    @@ -92,11 +92,10 @@
                         logger.error(message, t);
                     }
                 }
    -        } else {
    -            // Return defaults for now
    -            relationships.add(REL_SUCCESS);
    -            relationships.add(REL_FAILURE);
             }
    +        // Add defaults
    +        relationships.add(REL_SUCCESS);
    +        relationships.add(REL_FAILURE);
    --- End diff --
    
    Yeah if this is failing tests, I'd say take a look at the tests. We don't 
want to add default relationships, especially when there's a legit instance of 
a Processor, as it is the Processor's responsibility to define all relationships


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to