Koji, Just as a side note, you must perform a separate grunt deploy from the nifi-site repository for those changes to show up on the site. I took care of deploying so they would sync and they seem to be live.
--aldrin On Fri, Feb 10, 2017 at 7:43 PM, Koji Kawamura <ijokaruma...@gmail.com> wrote: > Thanks Otto, I reviewed pr1497 and merged it. > For the getting started page, I assume you were referring this quick start. > https://nifi.apache.org/quickstart.html > > I've modified the Java 8 version description as follows: > "You need a recent Java 8 (or newer) JDK for the 1.x NiFi line. Older > Java 8 (such as 1.8.0_31) is known to fail with some unit tests, > ensure to use the most recent version. The 0.x line works on Java 7 or > newer." > https://github.com/apache/nifi-site/blob/master/src/ > pages/markdown/quickstart.md#build-steps > > I think it takes a while for the HTML web page gets synchronized. > > On Sat, Feb 11, 2017 at 12:17 AM, Otto Fowler <ottobackwa...@gmail.com> > wrote: > > https://github.com/apache/nifi/pull/1497 > > > > > > On February 9, 2017 at 09:19:21, Koji Kawamura (ijokaruma...@gmail.com) > > wrote: > > > > Thanks! Please ping me when the PR is ready. > > > > On Thu, Feb 9, 2017 at 11:15 PM, Otto Fowler <ottobackwa...@gmail.com> > > wrote: > >> Sure - I see what you mean, that is a much better approach. > >> I will certainly do that. > >> > >> > >> > >> On February 9, 2017 at 09:02:05, Koji Kawamura (ijokaruma...@gmail.com) > >> wrote: > >> > >> Hi Otto, > >> > >> Thanks for reporting this. I personally haven't encountered this > >> issue, but as described here [1], when I opened the directory that the > >> test uses by Mac Finder application, and changed view as icon and move > >> the icon position, then a .DS_Store file was created. > >> > >> I agree with your workaround and I think we should resolve the issue. > >> By looking at the usage of that method, such as DBCPConnectionPool, or > >> JoltTransformJSON, those uses file name filter like this: > >> > >> (dir, name) -> name != null && name.endsWith(".jar") > >> > >> While filtering out specific .DS_Store works, targeting only name > >> ending with .jar looks more generic work around. > >> > >> Would you mind open a JIRA and send a PR? I'd happy to review! > >> > >> Thanks, > >> Koji > >> > >> On Thu, Feb 9, 2017 at 1:20 PM, Otto Fowler <ottobackwa...@gmail.com> > >> wrote: > >>> If it turns out that this *is* something you would like addressed, I > can > >>> do > >>> the jira and the PR > >>> > >>> > >>> On February 8, 2017 at 23:13:16, Otto Fowler (ottobackwa...@gmail.com) > >>> wrote: > >>> > >>> @Test > >>> public void testGetURLsForClasspathWithDirectory() throws > >>> MalformedURLException { > >>> final String jarFilePath = "src/test/resources/TestClassLoaderUtils"; > >>> URL[] urls = ClassLoaderUtils.getURLsForClasspath(jarFilePath, > >>> (dir,name)->name.compareTo(".DS_Store") == 0, false); > >>> assertEquals(2, urls.length); > >>> } > >>> > >>> > >>> resolves the issue, and I am able to build everything. > >>> > >>> > >>> On February 8, 2017 at 22:39:53, Otto Fowler (ottobackwa...@gmail.com) > >>> wrote: > >>> > >>> Hi, > >>> > >>> I’m trying to build master on Mac OS X, following the instructions from > >>> the > >>> site linked in the README.md. > >>> > >>> My build is failing because the unit test: > >>> testGetURLsForClasspathWithDirectory > >>> in TestClassLoaderUtils. > >>> > >>> It is trying to URLs from a directory, and is expecting 2, but gets 3, > >>> because the DS_STORE is detected and has an url built and returned for > >>> it. > >>> > >>> The test does not pass in a FileNamesFilter, which could be used to > >>> filter > >>> these files out I suppose. > >>> > >>> I am wondering if anyone is building successfully on Mac OS X? >
