+1 (binding) - verified hashes and signature - checked over the README, LICENSE and NOTICE - build without issue on ubuntu 16.06 (x86_64) - ran a simple flow without problems
On Mon, May 8, 2017 at 10:57 AM, Kevin Doran <kdoran.apa...@gmail.com> wrote: > +1 (non-binding), despite one minor bug found, for which I opened > MINIFI-303 [1]. > > - Verified signature, hashes, git commit > - Built successfully (Mac OS 10.12.4) > - Verified tests (Mac OS 10.12.4) > - Verified linting > - Reviewed README, NOTICE, and LICENSE, both in source and in build output. > - Verified application works as expected with a few variants of flow > config file > > Potential future improvements (have not created JIRAs or searched for > existing JIRAs): > > - nifi.security.need.ClientAuth property not working when set to false > (MINIFI-303 opened) [1] > - Fix or note expected CMake Dev Warning [2] > - Fix or note expected for compile warnings for civetweb, built under the > thirdparty/ directory as part of the minifi build. [3] > > [1] https://issues.apache.org/jira/browse/MINIFI-303 > > [2] CMake Warning output: > > CMake Warning (dev) at libminifi/CMakeLists.txt:22 (project): > Policy CMP0048 is not set: project() command manages VERSION variables. > Run "cmake --help-policy CMP0048" for policy details. Use the > cmake_policy > command to set the policy and suppress this warning. > > The following variable(s) would be set to empty: > > PROJECT_VERSION_MAJOR > PROJECT_VERSION_MINOR > PROJECT_VERSION_PATCH > This warning is for project developers. Use -Wno-dev to suppress it. > > > [3] Example of civetweb warning: > > nifi-minifi-cpp-0.2.0-source/thirdparty/civetweb-1.9.1/src/civetweb.c:14680:56: > warning: expansion of date or time macro is not reproducible > [-Wdate-time] > NULL, NULL, block, sizeof(block), "Build: %s%s", > __DATE__, eol); > > > > On 5/8/17, 10:33, "Bryan Bende" <bbe...@gmail.com> wrote: > > +1 (binding) Release this package as nifi-minifi-cpp-0.2.0 > > - Verified signature and hashes > - Built on OSX > - Successfully ran binary using provided sample config for s2s > > > > On Mon, May 8, 2017 at 2:26 AM, Koji Kawamura <ijokaruma...@gmail.com> > wrote: > > +1 (non-binding) > > > > Full build and test finished successfully without any issue on OS X. > > > > Here are the things that I look forward in future improvements > (didn't > > check existing JIRAs): > > > > ------------------------------------------------------------ > -------------- > > 1. minifi.sh restart does not working? > > ------------------------------------------------------------ > -------------- > > > > 'bin/minifi.sh restart' stops existing process, although standard > > output shows it starts new process, no MiNiFi process is running > after > > restart command. > > > > $ ./bin/minifi.sh restart > > Restarting MiNiFi service > > Stopping MiNiFi (PID: 36353). > > Starting MiNiFi with PID 36575 and pid file > > /Users/koji/dev/minifi-0.2.0-vote/nifi-minifi-cpp-0.2.0- > source/test/nifi-minifi-cpp-0.2.0/bin/.minifi.pid > > > > (PID 36575 does not exist after running this command) > > > > ------------------------------------------------------------ > -------------- > > 2. How to connect an Output Port to a Processor? > > ------------------------------------------------------------ > -------------- > > > > I tried this "Bidirectional Site-To-Site Configuration" example. > > https://github.com/apache/nifi-minifi-cpp/tree/master/examples/ > BidirectionalSiteToSite > > > > Although it's well written and helpful for users to setup > > bidirectional data transfer between MiNiFi and NiFi, I could not find > > a way to process data at MiNiFi those are fetched from NiFi. > > > > The example describes how to setup remote 'Output Ports' at MiNiFi, > my > > MiNiFi seems being able to pull data from NiFi as described in the > > example. > > But it doesn't connect the output port to any further processors. I > > would like to connect it to LogAttribute processor, but couldn't > > configure the connection properly. > > > > It'd be more helpful if the example contains a connection from an > > Output port to a processor. > > > > Thanks, > > Koji > > > > > > On Mon, May 8, 2017 at 10:49 AM, Joe Witt <joe.w...@gmail.com> > wrote: > >> +1 (binding). > >> > >> L&N looks good in source and resulting binary. Full build and > >> packaging worked well on OSX. Resulting binary tested well using > >> sample config.yml flowing into NiFi. > >> > >> Really great progress in the release! > >> > >> Couple quick observations; did not file JIRAs or check if existing > >> ones already there > >> - s2s logging at info level probably annotates too many flowfile > >> attribute details > >> - this warning > >> '...[minifi log] [error] Site2Site HandShake Failed because > >> destination port is either invalid or full' > >> might want to rephrase to 'in a stopped state or full' > >> - I believe if these lines appear in the logs > >> ...[error] NiFi Provenance Repository database open > >> ./provenance_repository fail > >> ...[error] NiFi FlowFile Repository database open > ./flowfile_repository fail > >> Then MiNiFi dies on the next usage/movement of data. This pattern > >> occurred three times. The exact timing/correlation wasn't clear but > >> this was the only interesting thing I saw in the logs that roughly > >> correlated to the process terminations. > >> > >> Thanks > >> Joe > >> > >> On Sun, May 7, 2017 at 3:53 PM, Aldrin Piri <ald...@apache.org> > wrote: > >>> Hello Apache NiFi Community, > >>> > >>> I am pleased to be calling this vote for the source release of > Apache NiFi > >>> MiNiFi C++, nifi-minifi-cpp-0.2.0. > >>> > >>> The source archive, signature, and digests can be located at: > >>> > >>> Source Archive: > >>> > >>> https://dist.apache.org/repos/dist/dev/nifi/nifi-minifi-cpp/ > 0.2.0/nifi-minifi-cpp-0.2.0-source.tar.gz > >>> GPG armored signature: > >>> > >>> https://dist.apache.org/repos/dist/dev/nifi/nifi-minifi-cpp/ > 0.2.0/nifi-minifi-cpp-0.2.0-source.tar.gz.asc > >>> Source MD5: > >>> > >>> https://dist.apache.org/repos/dist/dev/nifi/nifi-minifi-cpp/ > 0.2.0/nifi-minifi-cpp-0.2.0-source.tar.gz.md5 > >>> Source SHA1: > >>> > >>> https://dist.apache.org/repos/dist/dev/nifi/nifi-minifi-cpp/ > 0.2.0/nifi-minifi-cpp-0.2.0-source.tar.gz.sha1 > >>> Source SHA256: > >>> > >>> https://dist.apache.org/repos/dist/dev/nifi/nifi-minifi-cpp/ > 0.2.0/nifi-minifi-cpp-0.2.0-source.tar.gz.sha256 > >>> > >>> The Git tag is minifi-cpp-0.2.0-RC2 > >>> The Git commit hash is fa913b4174e1c874ddb12e4901c48bd86a7f70e4 > >>> * > >>> https://git-wip-us.apache.org/repos/asf?p=nifi-minifi-cpp. > git;a=commit;h=fa913b4174e1c874ddb12e4901c48bd86a7f70e4 > >>> * > >>> https://github.com/apache/nifi-minifi-cpp/commit/ > fa913b4174e1c874ddb12e4901c48bd86a7f70e4 > >>> > >>> Checksums of nifi-minifi-cpp-0.2.0-source.tar.gz: > >>> MD5: f9d0f2db0b54ab4b020777669d979e90 > >>> SHA1: 05a49e3eb853ec4a35694fd4588df247805a5e3c > >>> SHA256: b88f471292281c5e503d6148c0aa6e > b4b4c60d3a6449e924c04ff4761af3ddcb > >>> > >>> Release artifacts are signed with the following key: > >>> https://people.apache.org/keys/committer/aldrin > >>> > >>> KEYS file available here: > >>> https://dist.apache.org/repos/dist/release/nifi/KEYS > >>> > >>> 67 issues were closed/resolved for this release: > >>> https://issues.apache.org/jira/secure/ReleaseNote.jspa? > version=12338790&projectId=12319921 > >>> > >>> Release note highlights can be found here: > >>> https://cwiki.apache.org/confluence/display/MINIFI/ > Release+Notes#ReleaseNotes-Versioncpp-0.2.0 > >>> > >>> The vote will be open for 72 hours and will close 10 May at 5PM > EDT [1]. > >>> > >>> Please download the release candidate and evaluate the necessary > items > >>> including checking hashes, signatures, build from source, and > test. Then > >>> please vote: > >>> > >>> [ ] +1 Release this package as nifi-minifi-cpp-0.2.0 > >>> [ ] +0 no opinion > >>> [ ] -1 Do not release this package because... > >>> > >>> Thanks! > >>> > >>> > >>> [1] You can determine this time for your local time zone at > >>> https://s.apache.org/minifi-cpp-0.2.0-rc2-close > > > >
