Filed https://issues.apache.org/jira/browse/NIFI-4021 And PullRequest https://github.com/apache/nifi/pull/1892
On Tue, Jun 6, 2017 at 10:54 AM, Koji Kawamura <ijokaruma...@gmail.com> wrote: > Hi Adam, Jeff, > > StandardFlowSynchronizerSpec relies on System.property so it can pass > if other test sets 'nifi.properties.file.path'. > I think I found how to fix the test class. I will create a JIRA and > send a PR for it. > > Thanks, > Koji > > On Tue, Jun 6, 2017 at 9:35 AM, Jeff <jtsw...@gmail.com> wrote: >> Hi Adam, >> >> StandardFlowSynchronizerSpec via command line maven on my MBP passes >> successfully, but I do see the same errors as you when running the tests >> for StandardFlowSynchronizerSpec through IntelliJ. >> >> On Mon, Jun 5, 2017 at 6:56 PM Adam Taft <a...@adamtaft.com> wrote: >> >>> Got past the first error, thanks Joey. Indeed, the non-root user was the >>> fix. >>> >>> Unfortunately, now I'm getting another test failure. Can anyone confirm >>> this one? >>> >>> Running org.apache.nifi.controller.StandardFlowSynchronizerSpec >>> Tests run: 4, Failures: 0, Errors: 4, Skipped: 0, Time elapsed: 0.677 sec >>> <<< FAILURE! - in org.apache.nifi.controller.StandardFlowSynchronizerSpec >>> scaling of /conf/scale-positions-flow-0.7.0.xml with encoding version >>> "null"(org.apache.nifi.controller.StandardFlowSynchronizerSpec) Time >>> elapsed: 0.485 sec <<< ERROR! >>> java.lang.NullPointerException: null >>> at >>> >>> org.apache.nifi.controller.StandardFlowSynchronizer.readFlowFromDisk(StandardFlowSynchronizer.java:558) >>> at >>> >>> org.apache.nifi.controller.StandardFlowSynchronizer.sync(StandardFlowSynchronizer.java:176) >>> at org.apache.nifi.controller.StandardFlowSynchronizerSpec.scaling of >>> #filename with encoding version >>> "#flowEncodingVersion"(StandardFlowSynchronizerSpec.groovy:83) >>> >>> scaling of /conf/scale-positions-flow-0.7.0.xml with encoding version >>> "0.7"(org.apache.nifi.controller.StandardFlowSynchronizerSpec) Time >>> elapsed: 0.047 sec <<< ERROR! >>> java.lang.NullPointerException: null >>> at >>> >>> org.apache.nifi.controller.StandardFlowSynchronizer.readFlowFromDisk(StandardFlowSynchronizer.java:558) >>> at >>> >>> org.apache.nifi.controller.StandardFlowSynchronizer.sync(StandardFlowSynchronizer.java:176) >>> at org.apache.nifi.controller.StandardFlowSynchronizerSpec.scaling of >>> #filename with encoding version >>> "#flowEncodingVersion"(StandardFlowSynchronizerSpec.groovy:83) >>> >>> scaling of /conf/scale-positions-flow-0.7.0.xml with encoding version >>> "1.0"(org.apache.nifi.controller.StandardFlowSynchronizerSpec) Time >>> elapsed: 0.036 sec <<< ERROR! >>> java.lang.NullPointerException: null >>> at >>> >>> org.apache.nifi.controller.StandardFlowSynchronizer.readFlowFromDisk(StandardFlowSynchronizer.java:558) >>> at >>> >>> org.apache.nifi.controller.StandardFlowSynchronizer.sync(StandardFlowSynchronizer.java:176) >>> at org.apache.nifi.controller.StandardFlowSynchronizerSpec.scaling of >>> #filename with encoding version >>> "#flowEncodingVersion"(StandardFlowSynchronizerSpec.groovy:83) >>> >>> scaling of /conf/scale-positions-flow-0.7.0.xml with encoding version >>> "99.0"(org.apache.nifi.controller.StandardFlowSynchronizerSpec) Time >>> elapsed: 0.037 sec <<< ERROR! >>> java.lang.NullPointerException: null >>> at >>> >>> org.apache.nifi.controller.StandardFlowSynchronizer.readFlowFromDisk(StandardFlowSynchronizer.java:558) >>> at >>> >>> org.apache.nifi.controller.StandardFlowSynchronizer.sync(StandardFlowSynchronizer.java:176) >>> at org.apache.nifi.controller.StandardFlowSynchronizerSpec.scaling of >>> #filename with encoding version >>> "#flowEncodingVersion"(StandardFlowSynchronizerSpec.groovy:83) >>> >>> Results : >>> Tests in error: >>> StandardFlowSynchronizerSpec.scaling of #filename with encoding version >>> "#flowEncodingVersion":83 ? NullPointer >>> StandardFlowSynchronizerSpec.scaling of #filename with encoding version >>> "#flowEncodingVersion":83 ? NullPointer >>> StandardFlowSynchronizerSpec.scaling of #filename with encoding version >>> "#flowEncodingVersion":83 ? NullPointer >>> StandardFlowSynchronizerSpec.scaling of #filename with encoding version >>> "#flowEncodingVersion":83 ? NullPointer >>> >>> >>> >>> >>> >>> >>> On Mon, Jun 5, 2017 at 4:18 PM, Adam Taft <a...@adamtaft.com> wrote: >>> >>> > OK, will check out root/non-root. Thanks for the heads up on that. Give >>> > me a minute, will check with a non-root user. >>> > >>> > Adam >>> > >>> > >>> > On Mon, Jun 5, 2017 at 4:12 PM, Joey Frazee <joey.fra...@icloud.com> >>> > wrote: >>> > >>> >> Adam, this can happen if you're building as root (E.g., if you're being >>> >> lazy like me and just using a disposable Docker container). >>> >> >>> >> NIFI-3836 is open for it. >>> >> >>> >> If this is what it is, just build as a non root user. >>> >> >>> >> > On Jun 5, 2017, at 5:25 PM, Adam Taft <a...@adamtaft.com> wrote: >>> >> > >>> >> > I'm getting a test failure for this RC. Here is the maven snippet. >>> >> > >>> >> > ------------------------------------------------------- >>> >> > T E S T S >>> >> > ------------------------------------------------------- >>> >> > Running org.apache.nifi.provenance.CryptoUtilsTest >>> >> > Tests run: 16, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 0.761 >>> >> sec >>> >> > <<< FAILURE! - in org.apache.nifi.provenance.CryptoUtilsTest >>> >> > testShouldNotValidateUnreadableFileBasedKeyProvider(org.apac >>> >> he.nifi.provenance.CryptoUtilsTest) >>> >> > Time elapsed: 0.052 sec <<< FAILURE! >>> >> > org.codehaus.groovy.runtime.powerassert.PowerAssertionError: assert >>> >> > !unreadableKeyProviderIsValid >>> >> > || >>> >> > |true >>> >> > false >>> >> > at >>> >> > org.codehaus.groovy.runtime.InvokerHelper.assertFailed(Invok >>> >> erHelper.java:402) >>> >> > at >>> >> > org.codehaus.groovy.runtime.ScriptBytecodeAdapter.assertFail >>> >> ed(ScriptBytecodeAdapter.java:650) >>> >> > at >>> >> > org.apache.nifi.provenance.CryptoUtilsTest.testShouldNotVali >>> >> dateUnreadableFileBasedKeyProvider(CryptoUtilsTest.groovy:214) >>> >> > Results : >>> >> > Failed tests: >>> >> > CryptoUtilsTest.testShouldNotValidateUnreadableFileBasedKeyP >>> >> rovider:214 >>> >> > assert !unreadableKeyProviderIsValid >>> >> > || >>> >> > |true >>> >> > false >>> >> > >>> >> > I'm running from a clean docker container from centos:latest. I >>> >> installed >>> >> > openjdk-1.8.0-devel and maven 3.5.0 into the container. The openjdk >>> >> comes >>> >> > with the crypto extensions, so I don't think this is the problem. >>> >> > >>> >> > Any thoughts on the above? >>> >> > >>> >> > By the way, the signatures and hashes look good. However I don't see >>> a >>> >> > 1.3.0-RC1 tag, as per your email. >>> >> > >>> >> > Thanks, >>> >> > >>> >> > Adam >>> >> > >>> >> > p.s. here's more environment info: >>> >> > >>> >> > [root@0e3de1bf9bfc nifi-1.3.0]# mvn --version >>> >> > Apache Maven 3.5.0 (ff8f5e7444045639af65f6095c62210b5713f426; >>> >> > 2017-04-03T19:39:06Z) >>> >> > Maven home: /opt/apache-maven-3.5.0 >>> >> > Java version: 1.8.0_131, vendor: Oracle Corporation >>> >> > Java home: /usr/lib/jvm/java-1.8.0-openjdk-1.8.0.131-3.b12.el7_3.x86_ >>> >> 64/jre >>> >> > Default locale: en_US, platform encoding: ANSI_X3.4-1968 >>> >> > OS name: "linux", version: "4.9.27-moby", arch: "amd64", family: >>> "unix" >>> >> > [root@0e3de1bf9bfc nifi-1.3.0]# uname -a >>> >> > Linux 0e3de1bf9bfc 4.9.27-moby #1 SMP Thu May 11 04:01:18 UTC 2017 >>> >> x86_64 >>> >> > x86_64 x86_64 GNU/Linux >>> >> > [root@0e3de1bf9bfc nifi-1.3.0]# cat /etc/redhat-release >>> >> > CentOS Linux release 7.3.1611 (Core) >>> >> > >>> >> > >>> >> > >>> >> > >>> >> >> On Mon, Jun 5, 2017 at 11:54 AM, Matt Gilman <mcgil...@apache.org> >>> >> wrote: >>> >> >> >>> >> >> Hello, >>> >> >> >>> >> >> >>> >> >> I am pleased to be calling this vote for the source release of Apache >>> >> NiFi >>> >> >> nifi-1.3.0. >>> >> >> >>> >> >> >>> >> >> The source zip, including signatures, digests, etc. can be found at: >>> >> >> >>> >> >> >>> https://repository.apache.org/content/repositories/orgapachenifi-1108 >>> >> >> >>> >> >> >>> >> >> The Git tag is nifi-1.3.0-RC1 >>> >> >> >>> >> >> The Git commit ID is ddb73612bd1512d8b2151b81f9aa40811bca2aaa >>> >> >> >>> >> >> https://git-wip-us.apache.org/repos/asf?p=nifi.git;a=commit;h= >>> >> >> ddb73612bd1512d8b2151b81f9aa40811bca2aaa >>> >> >> >>> >> >> >>> >> >> Checksums of nifi-1.3.0-source-release.zip: >>> >> >> >>> >> >> MD5: 8b115682ac392342b9edff3bf0658ecb >>> >> >> >>> >> >> SHA1: f11cdebbabdc0d8f1f0dd4c5b880ded39d17f234 >>> >> >> >>> >> >> SHA256: 9ba5565729d98c472c31a1fdbc44e9dc1eee87a2cf5184e8428743f75314 >>> >> 5b7f >>> >> >> >>> >> >> >>> >> >> Release artifacts are signed with the following key: >>> >> >> >>> >> >> https://people.apache.org/keys/committer/mcgilman.asc >>> >> >> >>> >> >> >>> >> >> KEYS file available here: >>> >> >> >>> >> >> https://dist.apache.org/repos/dist/release/nifi/KEYS >>> >> >> >>> >> >> >>> >> >> 110 issues were closed/resolved for this release: >>> >> >> >>> >> >> https://issues.apache.org/jira/secure/ReleaseNote.jspa? >>> >> >> projectId=12316020&version=12340498 >>> >> >> >>> >> >> >>> >> >> Release note highlights can be found here: >>> >> >> >>> >> >> https://cwiki.apache.org/confluence/display/NIFI/ >>> >> >> Release+Notes#ReleaseNotes-Version1.3.0 >>> >> >> >>> >> >> >>> >> >> The vote will be open for 72 hours. >>> >> >> >>> >> >> Please download the release candidate and evaluate the necessary >>> items >>> >> >> including checking hashes, signatures, build from source, and test. >>> >> The >>> >> >> please vote: >>> >> >> >>> >> >> >>> >> >> [ ] +1 Release this package as nifi-1.3.0 >>> >> >> >>> >> >> [ ] +0 no opinion >>> >> >> >>> >> >> [ ] -1 Do not release this package because... >>> >> >> >>> >> >>> > >>> > >>>
