+1 (non-binding) Verified hashes, built and ran all tests, built docker and ran all integration tests. Ran a simple test flow.
I did run into one minor issue, which is if virtualenv is configured with python3 by default then creating the virtual environment for the pytest integration tests fails. As this only affects integration tests in some environments, and not the library or agent, I don't think it is a concern for the purpose of the RC vote. It's an easy fix as well... I opened MINIFICPP-318 [1] and submitted a PR [2]. Thanks to everyone who has contributed the many features and improvements since the last release, and thanks Marc for pulling the RC together! [1] https://issues.apache.org/jira/browse/MINIFICPP-318 [2] https://github.com/apache/nifi-minifi-cpp/pull/204 Thanks, Kevin On 11/22/17, 18:42, "Aldrin Piri" <aldrinp...@gmail.com> wrote: +1, binding Built, tested, and created Docker container on OS X 10.12 and Centos 7.3 Ran a few flows and verified expected functionality on both systems. Thanks for getting this RC together! On Wed, Nov 22, 2017 at 10:49 AM, Jeremy Dyer <jdy...@gmail.com> wrote: > Your right let’s not put out another release for this since it can be > simply fixed by using the flags you provided. I went through the build > again and validated the runtime. Everything looks good now so I’m changing > my vote to a > > +1 > > - Jeremy > > > On Nov 22, 2017, at 10:31 AM, Marc <phroc...@apache.org> wrote: > > > > Jeremy, > > Thanks for your vote. > > > > Your version of GCC will likely cause this warnings due to spec > > additions, and since RocksDB fails on any warning your build failed as > well. > > > > Please try the following before running make: *cmake -DPORTABLE=ON > > -DFAIL_ON_WARNINGS= ..* > > > > I am not in favor of upgrading the version of RocksDB before another RC > > to address the issue, if it does ( there are others to address as well ). > > RocksDB created another release which I think may address this particular > > warning, but others may cause the build to fail. In some cases these > > warnings are simply to address potential performance issues. > > > > In regards to your -1, I'm happy to put out another RC that hardcodes > the > > option* -DFAIL_ON_WARNINGS= *, effectively disabling the failure, but I'm > > on the fence about that. Should I simply augment the procedures? Would > love > > input. > > > > Upgrading RocksDB introduces risk too, of course. The previous plan was > > to merge an updated PR for RocksDB shortly after this release to avoid > > incurring additional risk for 0.3.0. > > > > Thanks, > > Marc > > > > > > > >> On Wed, Nov 22, 2017 at 9:09 AM, Jeremy Dyer <jdy...@gmail.com> wrote: > >> > >> -1 Marc I'm having trouble getting this to build using Ubuntu 17.10 with > >> GCC version "gcc (Ubuntu 7.2.0-8ubuntu3) 7.2.0" seems to be an issue > with > >> building RocksDB with this version of GCC. Looks like there is an > update of > >> RocksDB where this would work however. What do you think? > >> > >>> On Tue, Nov 21, 2017 at 3:06 PM, Marc <phroc...@apache.org> wrote: > >>> > >>> Hello Apache NiFi Community, > >>> > >>> I am pleased to be calling this vote for the source release of Apache > >> NiFi > >>> MiNiFi C++, nifi-minifi-cpp-0.3.0. > >>> > >>> The source archive, signature, and digests can be located at: > >>> > >>> Source Archive: > >>> > >>> https://dist.apache.org/repos/dist/dev/nifi/nifi-minifi-cpp/ > >>> 0.3.0/nifi-minifi-cpp-0.3.0-source.tar.gz > >>> GPG armored signature: > >>> > >>> https://dist.apache.org/repos/dist/dev/nifi/nifi-minifi-cpp/ > >>> 0.3.0/nifi-minifi-cpp-0.3.0-source.tar.gz.asc > >>> Source MD5: > >>> > >>> https://dist.apache.org/repos/dist/dev/nifi/nifi-minifi-cpp/ > >>> 0.3.0/nifi-minifi-cpp-0.3.0-source.tar.gz.md5 > >>> Source SHA1: > >>> > >>> https://dist.apache.org/repos/dist/dev/nifi/nifi-minifi-cpp/ > >>> 0.3.0/nifi-minifi-cpp-0.3.0-source.tar.gz.sha1 > >>> Source SHA256: > >>> > >>> https://dist.apache.org/repos/dist/dev/nifi/nifi-minifi-cpp/ > >>> 0.3.0/nifi-minifi-cpp-0.3.0-source.tar.gz.sha256 > >>> > >>> The Git tag is minifi-cpp-0.3.0-RC1 > >>> The Git commit hash is d3852a73beaafa78a789d975f6d3a595b7761d41 > >>> * > >>> https://git-wip-us.apache.org/repos/asf?p=nifi-minifi-cpp. > >> git;a=commit;h= > >>> d3852a73beaafa78a789d975f6d3a595b7761d41 > >>> * > >>> https://github.com/apache/nifi-minifi-cpp/commit/ > >>> d3852a73beaafa78a789d975f6d3a595b7761d41 > >>> > >>> Checksums of nifi-minifi-cpp-0.3.0-source.tar.gz: > >>> MD5: 8bcc8987e8322e1be0ddc631adc4f9bd > >>> SHA1: 811cc8c54572f25121b64b123a8fca176e81509b > >>> SHA256: f87815c31b5b15a30d2261800a89d9eab678d5ecc485d53f83c035d6ddb3 > 1b8a > >>> > >>> Release artifacts are signed with the following key: > >>> https://people.apache.org/keys/committer/phrocker > >>> > >>> KEYS file available here: > >>> https://dist.apache.org/repos/dist/dev/nifi/KEYS > >>> > >>> 59 issues were closed/resolved for this release: > >>> https://issues.apache.org/jira/secure/ReleaseNote.jspa? > >>> projectId=12321520&version=12341640 > >>> > >>> Release note highlights can be found here: > >>> https://cwiki.apache.org/confluence/display/MINIFI/ > >>> Release+Notes#ReleaseNotes-Versioncpp-0.3.0 > >>> > >>> Since Thursday is a major US Holiday, the vote will be open for 96 > hours > >>> and will close on 25 Nov at 3PM EDT [1]. > >>> > >>> Please download the release candidate and evaluate the necessary items > >>> including checking hashes, signatures, build from source, and test. > Then > >>> please vote: > >>> > >>> [ ] +1 Release this package as nifi-minifi-cpp-0.3.0 > >>> [ ] +0 no opinion > >>> [ ] -1 Do not release this package because... > >>> > >>> Thanks! > >>> > >>> > >>> [1] You can determine this time for your local time zone at > >>> https://s.apache.org/minifi-cpp-0.3.0-rc1-close > >>> > >> >
